Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Object movement sounds get triggered when another object is moving #22

Closed
ClementSparrow opened this issue Aug 19, 2021 · 2 comments
Closed
Labels
bug Something isn't working games Concerns the games: exported, gist-loaded, or played in the editor.

Comments

@ClementSparrow
Copy link
Owner

See this example: pressing left triggers the sound of the crate moving even if the crate does not move in the end.

The reason is the test in repositionEntitiesOnLayer is bugged and will trigger a motion sound if the moving object is present in the cell and has a motion set, but it does not check that the object is actually in the layer considered. So, sounds will be triggered for all objects in that cell with motion when at least one object is successfully moving without colliding (even if it has no motion sound).

@increpare, the bug also exists in PuzzleScript, but you might want to wait that I have fixed it, since I'm working on it.

@ClementSparrow ClementSparrow added bug Something isn't working games Concerns the games: exported, gist-loaded, or played in the editor. labels Aug 19, 2021
@increpare
Copy link

Good catch!

@ClementSparrow
Copy link
Owner Author

Actually, there is still a bug: in this example, sound should be triggered when a target or a red crate moves, but it is triggered also when the cell contains a target and a moving object that is not a red crate but belongs to the same collision layer than red crates (player, orange crate...)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working games Concerns the games: exported, gist-loaded, or played in the editor.
Projects
None yet
Development

No branches or pull requests

2 participants