Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Left/Right in a process tree should collapse/expand the tree branches #1304

Closed
1 task done
nyurik opened this issue Oct 9, 2023 · 5 comments · May be fixed by #1306
Closed
1 task done

Left/Right in a process tree should collapse/expand the tree branches #1304

nyurik opened this issue Oct 9, 2023 · 5 comments · May be fixed by #1306
Labels
feature Requests for a new feature.

Comments

@nyurik
Copy link
Contributor

nyurik commented Oct 9, 2023

Checklist

Describe the feature request

Many tree viewers have a convention of opening/closing tree branches when the user hits left/right arrow keys. Please add for consistency. Thanks!

@nyurik nyurik added the feature Requests for a new feature. label Oct 9, 2023
@ClementTsang
Copy link
Owner

Hm, I was originally planning on defaulting left/right in the process widget to deal with #433.

@nyurik
Copy link
Contributor Author

nyurik commented Oct 10, 2023

I did a first pass of implementing it in #1306 -- I think toggle on + and - is a bit confusing too, so I changed it as well.

The horizontal scrolling might be good, just probably not as common for the tree view? Perhaps ctrl+left/right?

@ClementTsang
Copy link
Owner

Closing this in favour of #454 which is more general.

@nyurik
Copy link
Contributor Author

nyurik commented Dec 20, 2023

@ClementTsang thanks for implementing the custom bindings, but please consider convention over configuration (common in Rust) -- which is the most obvious tree behavior?

@ClementTsang
Copy link
Owner

ClementTsang commented Dec 20, 2023

Honestly, the first tool I think of with trees and processes that is similar to this use case is htop... which doesn't do what you describe either, as far as I'm aware, hence why I was not really on board at first.

That said yes, I can consider it, as I'm aware many other programs do act like this after playing around with a few, and I'll consider adding it as a default keybinding.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Requests for a new feature.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants