-
Notifications
You must be signed in to change notification settings - Fork 331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Body scroll should be restored when detached mode is responsively removed #1250
Body scroll should be restored when detached mode is responsively removed #1250
Comments
I am interested in taking this up. I checked the sandbox and opened the app in a new tab. For large screen, you can scroll the entire page but for mobile view or smaller screen, somehow the scroll event is not getting activated. |
One solution I can think of can't we keep the cancel button even in big screen? Like in my opinion, its still pretty frustating that I can't close the search menu after opening it. I guess we can keep a backdrop in the background when opening the search bar so as to let the user know they can't make change in the background before making their search. |
@career-tokens I have a fixed posted on #1251 My team is using a forked version based on that fix in production, and all is well. Waiting on code review + tests and hopefully it will merge soon |
Thanks for letting me know. I don't know whether I should ask it here but can you let me know whether you have NextJS based repositories with good first issues? |
Description
Body scroll should be restored when detached mode is responsively removed
Reproduction
Preview → - default sandbox has the bug
Steps
Expected behavior
Environment
The text was updated successfully, but these errors were encountered: