Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FileReader module #5

Closed
juliasloan25 opened this issue Sep 11, 2023 · 0 comments · Fixed by #19
Closed

FileReader module #5

juliasloan25 opened this issue Sep 11, 2023 · 0 comments · Fixed by #19
Labels
new module 🚨 Implementation of a new module

Comments

@juliasloan25
Copy link
Member

juliasloan25 commented Sep 11, 2023

Create a module for reading in data from files, which may contain data at one or multiple points in time. This code was restructured for the ClimaLSM version to have a more logical structure and cleaner layout. In our implementation here, we want to develop more similarly to the ClimaLSM approach. Reconciling these two versions may result in this module requiring more work than the other modules since they differ more between the two repos.

Note: The nans_to_zero function of ClimaLSM's Regridder module should be moved to the FileReader module, along with new missings_to_zero and clean_data functions. https://github.com/CliMA/ClimaLSM.jl/blob/main/src/shared_utilities/Regridder.jl#L13

ClimaCoupler.jl BCReader module: https://github.com/CliMA/ClimaCoupler.jl/blob/main/src/BCReader.jl
ClimaLSM.jl FileReader module: https://github.com/CliMA/ClimaLSM.jl/blob/main/src/shared_utilities/FileReader.jl

ClimaCoupler.jl BCReader tests: https://github.com/CliMA/ClimaCoupler.jl/blob/main/test/bcreader_tests.jl
ClimaLSM.jl FileReader tests: https://github.com/CliMA/ClimaLSM.jl/blob/main/test/shared_utilities/file_reader.jl

tracked by #39

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new module 🚨 Implementation of a new module
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant