-
Notifications
You must be signed in to change notification settings - Fork 574
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce number of running containers in CI to one per run #1406
Comments
hello, have you thought about running docker container in CI and make connections to this clickhouse container? PS, ooohh, also i should have ability to run locally, my bad.... |
CI is using running ClickHouse in container. |
i meant use i had such experience integration-test:
runs-on: ubuntu-latest
services:
postgres:
image: postgres:16.3
env:
POSTGRES_DB: postgres
POSTGRES_USER: postgres
POSTGRES_PASSWORD: 5432
ports:
- 5432:5432
options: --health-cmd pg_isready --health-interval 10s --health-timeout 5s --health-retries 5
steps:
- name: Checkout code
uses: actions/checkout@v4
- name: Install Go
uses: actions/setup-go@v4
with:
go-version: '1.22'
cache: true
- name: Build
run: |
go mod tidy
go build ./...
- name: Test
env:
CONFIG_PATH: ${{ github.workspace }}/config.yaml
run: CGO_ENABLED=1 go test ./... -v -race -tags=integration |
@romanchechyotkin no, as it's going for specific CI runners. We expect the test to be run with We don't want to maintain two ways of running dependencies. |
Observed
Each CI tests run creates a few ClickHouse containers per test directory. This is an unnecessary overhead that could be reduced to a single container per run.
Expected behaviour
Run a single ClickHouse container per tests run.
The text was updated successfully, but these errors were encountered: