Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix incorrect nested array value #1223

Merged
merged 1 commit into from
Feb 10, 2023
Merged

fix incorrect nested array value #1223

merged 1 commit into from
Feb 10, 2023

Conversation

zhicwu
Copy link
Contributor

@zhicwu zhicwu commented Feb 3, 2023

Summary

Checklist

Delete items not relevant to your PR:

  • Unit and integration tests covering the common scenarios were added
  • A human-readable description of the changes was provided to include in CHANGELOG
  • For significant changes, documentation in https://github.com/ClickHouse/clickhouse-docs was updated with further explanations or tutorials

@zhicwu zhicwu marked this pull request as draft February 3, 2023 14:15
@zhicwu zhicwu linked an issue Feb 3, 2023 that may be closed by this pull request
@zhicwu
Copy link
Contributor Author

zhicwu commented Feb 3, 2023

Will merge tomorrow after benchmarking. The flaky tests on the other will be fixed(or disabled) in a separate PR.

-- works in 0.4.0
select [[1,2],[2,1],[3,4]]::Array(Array(Int8))

-- fixed 0.4.1
select [[1,2],[2,1],[3,4]]::Array(Array(Nullable(Int8)))
select [['aa','bb'],['cc','dd']]::Array(Array(String))
select [[['aa','bb'],['cc','dd']],[['aa2','bb1'],['cc1','dd2']]]::Array(Array(Array(String)))

@zhicwu
Copy link
Contributor Author

zhicwu commented Feb 10, 2023

The fix works at the cost of higher memory usage for nested arrays. Also I spotted issue in piped output stream during benchmarking. Should be good to merge this one first and fix other issues in separate PRs.

@zhicwu zhicwu marked this pull request as ready for review February 10, 2023 16:25
@zhicwu zhicwu merged commit bf885a9 into ClickHouse:main Feb 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nested arrays seem to be broken in 0.4.0
1 participant