Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[client-v2] Handling errors from a server #1821

Closed
chernser opened this issue Sep 12, 2024 · 2 comments · Fixed by #1883
Closed

[client-v2] Handling errors from a server #1821

chernser opened this issue Sep 12, 2024 · 2 comments · Fixed by #1883

Comments

@chernser
Copy link
Contributor

When compression is on (default case) and error happens - it is read from a raw stream, but should be wrapped with LZ4 Input Stream.

Steps to reproduce

  1. send query select asd123
  2. observe error with non-ascii symbols

Expected behavior

Error message should be a human readable string

Code example

Error log

Configuration

Environment

  • Client version:
  • Language version:
  • OS:

ClickHouse server

  • ClickHouse Server version:
  • ClickHouse Server non-default settings, if any:
  • CREATE TABLE statements for tables involved:
  • Sample data for all these tables, use clickhouse-obfuscator if necessary
@chernser chernser added the bug label Sep 12, 2024
@chernser chernser added this to the 0.7.0 milestone Sep 12, 2024
@chernser chernser modified the milestones: 0.7.0, 0.7.1 Oct 1, 2024
@Am-phi
Copy link
Contributor

Am-phi commented Oct 19, 2024

@chernser
Didn't you already fixed this issue in #1830 ? Your description seems reproducible before this PR, and not after it.

@chernser
Copy link
Contributor Author

Good day, @Am-phi!
yes, #1830 fixes most of the problems and I left issue open to test more and fix may be edge cases.
There is a tricky case when error is within data stream in the format of the data stream. It is fixed too, but I would spend sometime for additional tests.

@chernser chernser changed the title [client-v2] Incorrect read of server error when server response is compressed [client-v2] Handling errors from a server Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants