Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The code annotation (about 'enable_http_compression') is wrong. #134

Closed
ghost opened this issue Feb 13, 2023 · 2 comments
Closed

The code annotation (about 'enable_http_compression') is wrong. #134

ghost opened this issue Feb 13, 2023 · 2 comments
Labels
documentation Improvements or additions to documentation enhancement New feature or request

Comments

@ghost
Copy link

ghost commented Feb 13, 2023

The default value of option 'enable_http_compression' is not false

    /** Compress the result if the client over HTTP said that it understands data compressed by gzip or deflate. (default: false) */
    enable_http_compression?: Bool;

Unlike the option default value specified as false when creating a client that inquires DB with a Readonly user,
The error below is exposed.
Cannot modify 'enable_http_compression' setting in readonly mode.

REF:

/** Compress the result if the client over HTTP said that it understands data compressed by gzip or deflate. (default: false) */

@slvrtrn
Copy link
Contributor

slvrtrn commented Feb 15, 2023

Thanks for pointing it out.

That one we parsed from the server-side C++ code of ClickHouse itself (for example this), so the default value mention is coming from those comment sections.

The reason why we added these additional typings is that you could provide these settings on a query basis (for example), so it is better to have some types there for development experience in the IDE.

I guess we should remove any mention of default there, as the client actually has it true for requests by default.

@slvrtrn slvrtrn added documentation Improvements or additions to documentation enhancement New feature or request labels Feb 15, 2023
This was referenced Jul 24, 2023
@slvrtrn
Copy link
Contributor

slvrtrn commented Jul 26, 2023

Resolved by #193

@slvrtrn slvrtrn closed this as completed Jul 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant