Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hyphens in metric names causing scrape failures #66

Open
jpiper opened this issue Nov 9, 2021 · 1 comment
Open

hyphens in metric names causing scrape failures #66

jpiper opened this issue Nov 9, 2021 · 1 comment

Comments

@jpiper
Copy link

jpiper commented Nov 9, 2021

In the latest clickhouse version, clickhouse is exporting metrics about devices, and this is generating metric names with hyphens in them, which are not valid for prometheus and scraping fails

# HELP clickhouse_block_active_time_dm-0 Number of BlockActiveTime_dm-0 async processed
# TYPE clickhouse_block_active_time_dm-0 gauge
@jpiper jpiper mentioned this issue Nov 9, 2021
Closed
@vdimir
Copy link
Member

vdimir commented Nov 10, 2021 •
edited
Loading

I have no idea how it can happen, because on clickhouse server side we replace all chars except a-zA-Z0-9_: in metric name to _ ClickHouse/ClickHouse#26140

Could please you provide server version and config to reproduce problem?

UPD: got it, problem is connected to golang code in clickhouse_exporter and not related to embedded exporter

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Replace all hyphens with underscores in metrics jpiper/clickhouse_exporter
2 participants
@jpiper @vdimir