Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for 7.x #180

Open
Daniel-B-Smith opened this issue Feb 28, 2020 · 6 comments
Open

Add support for 7.x #180

Daniel-B-Smith opened this issue Feb 28, 2020 · 6 comments

Comments

@Daniel-B-Smith
Copy link
Contributor

Opening an issue since I'm about to start working on this and to get feedback before any PRs are sent out.

It looks like there are a couple of pieces added to the C API in 7.0: apple/foundationdb#2644 The change to keyvalue from void* to uint8_t* made it in, so that may require a change to the generated interface. I'm actively working on apple/foundationdb#2644, but that probably won't make it in until 7.1.

@Speedy37
Copy link
Contributor

The change to keyvalue from void* to uint8_t* made it in, so that may require a change to the generated interface.

I just made a change to prevent issues related to this: 129a688

We are generating both options.rs and foundationdb_sys from fdb.options and fdb_cli.h so we should already be quite safe to catch any breaking change at compile time.

@Daniel-B-Smith
Copy link
Contributor Author

That's great. All of the other changes to the C API should be strictly additive.

@PierreZ
Copy link

PierreZ commented Jul 1, 2021

Are you working on this feature @Daniel-B-Smith? I just pushed a PR for 6.3, and I was thinking about doing 7.X next.

@Daniel-B-Smith
Copy link
Contributor Author

I am not.

@PierreZ
Copy link

PierreZ commented Jul 5, 2021

Okay, I will try to open a 7.X PR once a pre-release is tagged.

@PierreZ
Copy link

PierreZ commented Nov 9, 2021

Initial work around api 700 can be found here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants