Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

load variants command has a parameter spelled wrong #5090

Open
northwestwitch opened this issue Nov 29, 2024 · 3 comments
Open

load variants command has a parameter spelled wrong #5090

northwestwitch opened this issue Nov 29, 2024 · 3 comments

Comments

@northwestwitch
Copy link
Member

Here :

"--rank-treshold",

@northwestwitch northwestwitch changed the title load variants command has parameter spelled wrong load variants command has a parameter spelled wrong Nov 29, 2024
@dnil
Copy link
Collaborator

dnil commented Nov 29, 2024

That spelling is common in the codebase, perhaps add a deprecation notice like the one here

help="Specify the rank score threshold. Deprecation warning: this parameter name will change in a later release.",

@dnil
Copy link
Collaborator

dnil commented Nov 29, 2024

ah. heehe, that was the same one! 😆

@dnil
Copy link
Collaborator

dnil commented Dec 2, 2024

Good reminder! The spelling was depreacated in #4799, but one could already add correctly spelled alias, and correct all internal (non-api/cli) use. Otherwise we would fix with v5 (#2357).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants