Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Number in tld makes url invalid #153

Closed
UmbraAtrox opened this issue May 9, 2023 · 7 comments
Closed

Number in tld makes url invalid #153

UmbraAtrox opened this issue May 9, 2023 · 7 comments
Labels
bug Something isn't working feature-request New feature or request

Comments

@UmbraAtrox
Copy link

Describe the bug
When a number is added to tld it makes the url invalid.

To Reproduce

  1. Add printer
  2. Enter printer-url "abc.ab1"

Expected behavior
App attempts to connect anyway (possibly after prompt to ask the user if they are really really really sure they didn't typo)

**Mobileraker-Version
2.2.4-156

@Clon1998 Clon1998 added bug Something isn't working feature-request New feature or request labels May 9, 2023
@Clon1998
Copy link
Owner

Clon1998 commented May 9, 2023

Hey,
As a temporary workaround, add the printer with the domain ending with e.g. ´.com´. Then go into the printer's setting page. There is no validation on that page on either the WS or the HTTP address input. Therefore, update the correct tld there for now.

@UmbraAtrox
Copy link
Author

Hey, As a temporary workaround, add the printer with the domain ending with e.g. ´.com´. Then go into the printer's setting page. There is no validation on that page on either the WS or the HTTP address input. Therefore, update the correct tld there for now.

There is no check on the printer-address but websocket-address does check, says 'Field requires a valid URL address' and doesn't let me save changes.

@Clon1998 Clon1998 added this to the Simple/Advanced PrinterAdd milestone May 19, 2023
@lifer0se
Copy link

Experiencing the same issue with mainsail.
I'm trying to add it using the host name, but "http://mainsail" does not pass validation on "add printer".
I can add the printer using its IP address and then edit the printer address, but the websocket address is still giving me trouble.

Any workarounds to not using a static IP? Could you maybe disable validation entirely?

@Clon1998
Copy link
Owner

Experiencing the same issue with mainsail.

I'm trying to add it using the host name, but "http://mainsail" does not pass validation on "add printer".

I can add the printer using its IP address and then edit the printer address, but the websocket address is still giving me trouble.

Any workarounds to not using a static IP? Could you maybe disable validation entirely?

The next release will offer a new add printer flow that allows to completely disabled validation.

If you are using iOS i can send you a TestFlight link. Otherwise you need to wait until it is ready.

@lifer0se
Copy link

The next release will offer a new add printer flow that allows to completely disabled validation.

If you are using iOS i can send you a TestFlight link. Otherwise you need to wait until it is ready.

Great to hear! it's not that big an issue for me right now, I just have to change the IP if router resets.

I am on iOS, so I'd like a TestFlight invite, I'm decent at beta testing :)

@Clon1998
Copy link
Owner

Here you go

https://testflight.apple.com/join/h9JwuyR0

@Clon1998
Copy link
Owner

Fixed in android2.5.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working feature-request New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants