Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance 'Output pin' behaviour #70

Closed
willkaxxx opened this issue Aug 21, 2022 · 13 comments
Closed

Enhance 'Output pin' behaviour #70

willkaxxx opened this issue Aug 21, 2022 · 13 comments
Labels
feature-request New feature or request

Comments

@willkaxxx
Copy link

willkaxxx commented Aug 21, 2022

  • Currently for output button we have got slider, even if it have only two positions
    image
    image

  • Could you please add ordinary button (on /off) , if output pin can take only two values?

  • Example from Fluidd
    image

Thanks!)

@Clon1998 Clon1998 added the feature-request New feature or request label Aug 21, 2022
@Clon1998
Copy link
Owner

Adding such an option should not be a problem. I'll add it once I am done migrating to a new framework.

@Fl0ken
Copy link

Fl0ken commented Apr 25, 2023

Adding to this: could the slider actually enable values between 0 and 1? I got a Daylight on the pin and can only do off/max brightness instead of changing the brightness.

@Clon1998
Copy link
Owner

Adding to this: could the slider actually enable values between 0 and 1? I got a Daylight on the pin and can only do off/max brightness instead of changing the brightness.

Hey, this depends on the output pin scale configuration. Make sure you set the configuration correctly to enable this!

@Clon1998
Copy link
Owner

@willkaxxx sorry for my WAY to late reply, I just went trough the issues and was wondering why this ticket is not closed yet since I implemented the logic for this ages ago. Turns out the config parsing for the output_pin was not working correctly causing the app to still use a slider instead of the new switch cards!

I included the fix in the upcoming version 2.3.0!

@Clon1998
Copy link
Owner

Added in 2.3.0

@Fl0ken
Copy link

Fl0ken commented May 20, 2023

Adding to this: could the slider actually enable values between 0 and 1? I got a Daylight on the pin and can only do off/max brightness instead of changing the brightness.

Hey, this depends on the output pin scale configuration. Make sure you set the configuration correctly to enable this!

Hey, will try scale when home, but shouldn't this also work if I got PWM enabled? I can already change the brightness in Mainsail.

@willkaxxx
Copy link
Author

Hey, @Clon1998 , I have tried to reinstal app, clean cashes, delete printer from configs.
But it still a slider :(
Could you suggest something to try more?
My current version is 2.3.1
My config in klipper like:
image

Thanks

@Clon1998 Clon1998 reopened this May 21, 2023
@Clon1998
Copy link
Owner

Adding to this: could the slider actually enable values between 0 and 1? I got a Daylight on the pin and can only do off/max brightness instead of changing the brightness.

Hey, this depends on the output pin scale configuration. Make sure you set the configuration correctly to enable this!

Hey, will try scale when home, but shouldn't this also work if I got PWM enabled? I can already change the brightness in Mainsail.

Good point, I will make sure that non pwm pins are always toggles/switches.

@Clon1998
Copy link
Owner

Hey, @Clon1998 , I have tried to reinstal app, clean cashes, delete printer from configs.

But it still a slider :(

Could you suggest something to try more?

My current version is 2.3.1

My config in klipper like:

image

Thanks

Hey,
I will check that. The pin I tested that with is defined like that
image

@Clon1998
Copy link
Owner

Clon1998 commented May 26, 2023

@willkaxxx, I just had another look and I simply can not reproduce this on my device (version 2.3.4).

See my test config:
image
image

@willkaxxx
Copy link
Author

@Clon1998 I have found the root cause, if name of pin is "LED" (upper case), it doesnt work as expected, but if I change naming to "led" (lower case), it works fine

@Clon1998
Copy link
Owner

@Clon1998 I have found the root cause, if name of pin is "LED" (upper case), it doesnt work as expected, but if I change naming to "led" (lower case), it works fine

That's interesting and definitely a Bug in mobileraker. I will double check my implementation.
Thanks for your reply!

@Clon1998
Copy link
Owner

Clon1998 commented Dec 6, 2023

I forgot to close this issue. The parsing for most klipper objects was reworked and the keys/config keys are now case-insensitive.

@Clon1998 Clon1998 closed this as completed Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants