-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance 'Output pin' behaviour #70
Comments
Adding such an option should not be a problem. I'll add it once I am done migrating to a new framework. |
Adding to this: could the slider actually enable values between 0 and 1? I got a Daylight on the pin and can only do off/max brightness instead of changing the brightness. |
Hey, this depends on the output pin |
@willkaxxx sorry for my WAY to late reply, I just went trough the issues and was wondering why this ticket is not closed yet since I implemented the logic for this ages ago. Turns out the config parsing for the I included the fix in the upcoming version |
Added in 2.3.0 |
Hey, will try |
Hey, @Clon1998 , I have tried to reinstal app, clean cashes, delete printer from configs. Thanks |
Good point, I will make sure that non pwm pins are always toggles/switches. |
Hey, |
@willkaxxx, I just had another look and I simply can not reproduce this on my device (version 2.3.4). |
@Clon1998 I have found the root cause, if name of pin is "LED" (upper case), it doesnt work as expected, but if I change naming to "led" (lower case), it works fine |
That's interesting and definitely a Bug in mobileraker. I will double check my implementation. |
I forgot to close this issue. The parsing for most klipper objects was reworked and the keys/config keys are now case-insensitive. |
Currently for output button we have got slider, even if it have only two positions
Could you please add ordinary button (on /off) , if output pin can take only two values?
Example from Fluidd
Thanks!)
The text was updated successfully, but these errors were encountered: