Signup Form label mismatch for error handling

[mtahafarooq]

I'm submitting a

(Check one with "x" from given options)

• Bug report
• Feature request

Current behavior

In sign up form when a user chooses a fully numeric password and clicks the submit button, the server returns a validation error but it does not get displayed under the password's form field.

Expected behavior

The system should show the validation error message under the password's form field.

Steps to reproduce

1. Open signup form.
2. Fill the password field with number.
3. Click submit button.
4. No validation error is shown.

Related screenshots

Other information

System information

Ubuntu 18.04 LTS

[mtahafarooq]

@Shekharrajak I've been able to fix this issue locally, the problem is that when the validation error is returned the field name is "password1" and when this label is passed to formItemForLabel function, it is unable to fetch the form item since the relevant form item has the label "password" and not "password1".
If we change the label to "password1" then it does gets fixed but then the label for the password field is "Password 1" which I think is not acceptable.
Other way to solve it is to fix the field on backend. What do you say?

[mtahafarooq]

@Shekharrajak I've done some research on backend and I see that rest_auth is being used and it requires the password fields to be password1 and password2.
Reference: https://django-rest-auth.readthedocs.io/en/latest/api_endpoints.html#registration

What do you say?

[Shekharrajak]

Thanks @mtahafarooq for pointing it out. Can you check once how this functionality works in https://github.com/Cloud-CV/EvalAI repo and if you find the same issue there as well, then we will go to backend otherwise front-end change will be sufficient.

[mtahafarooq]

@Shekharrajak it does not appear there. Should I make a PR with the fix?

[Shekharrajak]

@mtahafarooq , Yes go ahead .

[mtahafarooq]

Fixed #124