We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HTMLElement
element
currently, the default pagefind ui expects a query selector string as options.element, see https://github.com/CloudCannon/pagefind/blob/main/pagefind_ui/default/ui-core.js#L40
options.element
it would be nice if it were possible to directly pass in a reference to an html element as well, i.e.:
- const dom = document.querySelector(selector); + const dom = selector instanceof HTMLElement ? selector : document.querySelector(selector);
would you accept a pr for this?
The text was updated successfully, but these errors were encountered:
I would certainly accept a PR for this 🙂
Sorry, something went wrong.
Successfully merging a pull request may close this issue.
currently, the default pagefind ui expects a query selector string as
options.element
, see https://github.com/CloudCannon/pagefind/blob/main/pagefind_ui/default/ui-core.js#L40it would be nice if it were possible to directly pass in a reference to an html element as well, i.e.:
would you accept a pr for this?
The text was updated successfully, but these errors were encountered: