Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some translated strings still appear in english #374

Closed
RoneoOrg opened this issue Aug 3, 2023 · 9 comments
Closed

Some translated strings still appear in english #374

RoneoOrg opened this issue Aug 3, 2023 · 9 comments
Milestone

Comments

@RoneoOrg
Copy link

RoneoOrg commented Aug 3, 2023

Hi there,

as you can see in the screenshot below, the UI is displayed in French, but the "Clear" button is however in english:

pagefind-transliations

I checked in the repo and the french translation is complete, but some translations are not applied

@RoneoOrg
Copy link
Author

RoneoOrg commented Aug 3, 2023

Note that a second translation is not applied:

when the search form is empty, the english string "Search" is displayed, while the french string "Rechercher" should appear instead:

pagefind-2

@bglw bglw added this to the v1.0.0 milestone Sep 6, 2023
@bglw
Copy link
Contributor

bglw commented Sep 7, 2023

Hey @RoneoOrg thanks for the report — this will be fixed in the 1.0 release next week.

@itsmatteomanf
Copy link

I'm gonna add here, I have my page with lang="it", but the UI sticks to English. I manually translated the strings, but it should just work, right?

@bglw
Copy link
Contributor

bglw commented Sep 7, 2023

Hey @itsmatteomanf 👋

Looks like Italian translation strings were contributed after the current stable 0.12.0 release. They'll be available right now on the beta release tag, and will be in the 1.0 release 🙂

@bglw
Copy link
Contributor

bglw commented Sep 7, 2023

Screenshot 2023-09-08 at 8 17 20 AM

@itsmatteomanf
Copy link

I am using the 1.0.0 alpha releases, but I can check again...

@bglw
Copy link
Contributor

bglw commented Sep 7, 2023

NB: The fix for this issue where half of the strings sometimes appear untranslated is on the latest beta, not alpha. v1.0.0-beta.2 currently.

@itsmatteomanf
Copy link

itsmatteomanf commented Sep 7, 2023

I might have been running into the same issue as OP here, I had some translations, but not all.

v1.0.0-beta.2 solves it for me.

@bglw
Copy link
Contributor

bglw commented Sep 13, 2023

Hey all! 👋

Good news — this has landed in Pagefind v1.0.0! ✨

See the full release notes here: https://github.com/CloudCannon/pagefind/releases/tag/v1.0.0 💙

@bglw bglw closed this as completed Sep 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants