Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The code and software icp results are inconsistent #115

Open
darkdelting opened this issue Oct 29, 2024 · 7 comments
Open

The code and software icp results are inconsistent #115

darkdelting opened this issue Oct 29, 2024 · 7 comments
Labels
question Further information is requested

Comments

@darkdelting
Copy link

software:
image
image
image

code:
image
image
image

@dgirardeau
Copy link
Member

Sorry, I am not sure to fully understand the issue? Do you mean that the default parameters of the CCCoreLib library are different from the CloudCompare GUI version? (in which case that's definitely possible).

@darkdelting
Copy link
Author

Sorry, I am not sure to fully understand the issue? Do you mean that the default parameters of the CCCoreLib library are different from the CloudCompare GUI version? (in which case that's definitely possible).

Yes , I use the CloudCompare v2.13.2 and I'm not sure if it's the problem I'm using.

@dgirardeau
Copy link
Member

Well, CCCoreLib and CloudCompare are 2 different projects. They don't need to use the same default parameters.

@dgirardeau dgirardeau added the question Further information is requested label Oct 29, 2024
@darkdelting
Copy link
Author

darkdelting commented Oct 29, 2024

Well, CCCoreLib and CloudCompare are 2 different projects. They don't need to use the same default parameters.

Do you mean , That is CCCoreLib and CloudCompare are 2 different projects and use the same algorithm, but default parameters is different ? what is CloudCompare default parameters . Can I align the performance of the two algorithms?

@dgirardeau
Copy link
Member

You can see how CloudCompare calls CCCoreLib here:

Most of the parameters are set via the GUI, so it may not be simple to find the default values easily (you can also look at the dialog's ui file).

@darkdelting
Copy link
Author

Thanks for your anwser!! As you can see from the code, the parameters have been recalculated in the backend ,which is diffrent from ui
image
image
image

@dgirardeau
Copy link
Member

Well, 'baseIncrement' is just for memory allocation... We then simply update the overlap ratio to only consider points within the 'max search distance' (if any). Because the UI let's you play with various conflicting concepts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants