Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TemplateStorage#pull does not work in wrapper with relative paths #1303

Open
1 task done
DasBabyPixel opened this issue Aug 31, 2023 · 0 comments
Open
1 task done
Labels
s: needs triage Issue waiting for triage t: bug Something isn't working as intended

Comments

@DasBabyPixel
Copy link
Contributor

Stacktrace

No response

Actions to reproduce

Try to use TemplateStorage#pull in the Wrapper with a relative path as argument

CloudNet version

[31.08 10:46:54.357] INFO:
[31.08 10:46:54.357] INFO: CloudNet Blizzard 4.0.0-RC9 f6ca4c3
[31.08 10:46:54.358] INFO: Discord: https://discord.cloudnetservice.eu/
[31.08 10:46:54.358] INFO:
[31.08 10:46:54.358] INFO: ClusterId: deebb2f9--41cd--246e55129822
[31.08 10:46:54.359] INFO: NodeId: Node-1
[31.08 10:46:54.359] INFO: Head-NodeId: Node-1
[31.08 10:46:54.360] INFO: CPU usage: (P/S) .26/1.23/100%
[31.08 10:46:54.360] INFO: Node services memory allocation (U/R/M): 1536/1536/4096 MB
[31.08 10:46:54.360] INFO: Threads: 44
[31.08 10:46:54.361] INFO: Heap usage: 40/256MB
[31.08 10:46:54.361] INFO: JVM: Amazon.com Inc. 17 (OpenJDK 64-Bit Server VM 17.0.4.1+9-LTS)
[31.08 10:46:54.361] INFO: Update Repo: CloudNetService/launchermeta, Update Branch: beta
[31.08 10:46:54.362] INFO:

Other

It will not work because the relative Path gets serialized and sent to the Node where it will be deserialized again as a relative path. Now the process workingdirectory changed so the relative path lost its meaning

Issue uniqueness

  • Yes, this issue is unique. There are no similar issues.
@DasBabyPixel DasBabyPixel added s: needs triage Issue waiting for triage t: bug Something isn't working as intended labels Aug 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
s: needs triage Issue waiting for triage t: bug Something isn't working as intended
Projects
None yet
Development

No branches or pull requests

1 participant