Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve interface consistency for background operations #300

Open
nuwang opened this issue Jul 29, 2022 · 2 comments
Open

Improve interface consistency for background operations #300

nuwang opened this issue Jul 29, 2022 · 2 comments
Labels
enhancement

Comments

@nuwang
Copy link
Contributor

nuwang commented Jul 29, 2022

Some methods like stop_vm and restart_vm, block till the operation is complete. It would be better if they were non-blocking and returned an object that can be waited upon or queried for background operation status. In general, there seem to be some inconsistencies in how we are handling this.
@vineetjain27
Copy link

hey @nuwang I want to work into his issue can you please accept my contribution

@nuwang
Copy link
Contributor Author

nuwang commented Sep 7, 2022

@vineetjain27 We are happy to accept contributions. Please feel free to make a pull request with an initial implementation.

@nuwang nuwang changed the title Improve interface consistency for async operations Improve interface consistency for background operations Sep 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nuwang @vineetjain27