Skip to content
This repository has been archived by the owner on Dec 14, 2021. It is now read-only.

Add option for source file encoding to application settings #500

Closed
xueyayang opened this issue Oct 27, 2017 · 6 comments
Closed

Add option for source file encoding to application settings #500

xueyayang opened this issue Oct 27, 2017 · 6 comments
Assignees
Labels

Comments

@xueyayang
Copy link

xueyayang commented Oct 27, 2017

Version 2017.4.20 - 32 bit
Openning a cpp source file contains Chinese character(汉字),mainly comments,it displays wrong.
Is these a setting option to change the encoding of code window?

@mlangkabel
Copy link
Contributor

I think I managed to reproduce your issue by choosing the "Traditional Chinese" encoding to save the source file.

However, Sourcetrail is able to display these characters correctly
if the source file is encoded with "UTF-8 without BOM"

chinese_characters

@mlangkabel
Copy link
Contributor

Even though C++ doesn't allow any Chinese characters in code they can still be present in the comments. And since we shouldn't force every user to use UTF-8 to save their source files, we probably need to offer an option to pick the appropriate file encoding.

@mlangkabel mlangkabel changed the title Code windows support GBK encoding Add option for source file encoding to application settings Oct 27, 2017
@mlangkabel mlangkabel self-assigned this Oct 30, 2017
@xueyayang
Copy link
Author

Yes my source code is encoded with GBK2312,the default choosing of a chinese version visual studio on a chinese version windows·

Thx for your replying. Excellent Sofeware! I have used it about a week, it’s amazing. U guys are doing great work!

@mlangkabel
Copy link
Contributor

Implemented with Sourcetrail 2017.4.27

@xueyayang
Copy link
Author

Implemented with Sourcetrail 2017.4.27

When do i can download this version?

@egraether
Copy link
Contributor

It's available now as 2017.4.46: https://www.sourcetrail.com/downloads

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants