Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

the warning "Git SSH URLs will NOT work for ..." is annoying #190

Closed
gfx opened this issue Oct 21, 2014 · 10 comments · Fixed by CocoaPods/CocoaPods#2749
Closed

the warning "Git SSH URLs will NOT work for ..." is annoying #190

gfx opened this issue Oct 21, 2014 · 10 comments · Fixed by CocoaPods/CocoaPods#2749

Comments

@gfx
Copy link

gfx commented Oct 21, 2014

I use a private specs on our GitHub enterprise so I** have to** use Git SSH sources; cocoapods, however, produces warnings about it, stopping pod repo push with validation errors. Thus, I (and all the team members) always adds --allow-warnings in pod repo push.

I think it is too strict that a Git SSH URL is regarded as invalid by default. Can you please remove this warning, or make it just a notice instead of validation errors?

@alloy
Copy link
Member

alloy commented Oct 21, 2014

I agree that these should be a notice instead. Can you please create a PR for that?

@segiddins
Copy link
Member

@alloy over in CocoaPods we have an issue for a --private lint option

@gfx
Copy link
Author

gfx commented Oct 22, 2014

I'd like to make a pull-request but rake spec fails (https://gist.github.com/gfx/97b9a198d142d9b202f6 ).

--private looks good; adding a DSL could be better, I guess.

@alloy
Copy link
Member

alloy commented Oct 22, 2014

@segiddins I tried to find the issue about --private but couldn’t easily find it. If it’s only about this warning, though, then I wonder if we shouldn’t just change it to a notice instead. The core of the message remains helpful, but shouldn’t be treated as a warning imo.

@alloy
Copy link
Member

alloy commented Oct 22, 2014

I don’t want anything in the spec itself about the spec-repo it’s supposedly from. It doesn’t describe anything about the library.

@segiddins
Copy link
Member

@alloy see CocoaPods/CocoaPods#2682. I will (eventually) add a private mode to the validator that won't lint these things.

@segiddins
Copy link
Member

@fabiopelosin disagree, since a spec should be valid no matter where it is stored.

@fabiopelosin
Copy link
Member

I would rule out this possibility […]

Errata corrige: I wouldn't rule out this possibility so quickly, […].

I don't have a strong opinion.

@fabiopelosin disagree, since a spec should be valid no matter where it is stored.

The alternative that I described embodies more information in the Specification and, therefore, it makes easier to preserve the validation status independently from the repo where the Podspec is stored. It is unclear to me why the opposite would be case.

@alloy
Copy link
Member

alloy commented Nov 2, 2014

The validation is related to the repo the spec is pushed to nothing about the library itself. Adding an attribute for this leads to DSL creep and artificially imposes more restrictions, whereas we should let users do whatever they seem for their workflow.

@segiddins
Copy link
Member

Closing as a duplicate of CocoaPods/CocoaPods#2682.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants