-
Notifications
You must be signed in to change notification settings - Fork 349
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
the warning "Git SSH URLs will NOT work for ..." is annoying #190
Comments
I agree that these should be a notice instead. Can you please create a PR for that? |
@alloy over in CocoaPods we have an issue for a |
I'd like to make a pull-request but
|
@segiddins I tried to find the issue about |
I don’t want anything in the spec itself about the spec-repo it’s supposedly from. It doesn’t describe anything about the library. |
@alloy see CocoaPods/CocoaPods#2682. I will (eventually) add a |
@fabiopelosin disagree, since a spec should be valid no matter where it is stored. |
Errata corrige: I wouldn't rule out this possibility so quickly, […]. I don't have a strong opinion.
The alternative that I described embodies more information in the Specification and, therefore, it makes easier to preserve the validation status independently from the repo where the Podspec is stored. It is unclear to me why the opposite would be case. |
The validation is related to the repo the spec is pushed to nothing about the library itself. Adding an attribute for this leads to DSL creep and artificially imposes more restrictions, whereas we should let users do whatever they seem for their workflow. |
Closing as a duplicate of CocoaPods/CocoaPods#2682. |
I use a private specs on our GitHub enterprise so I** have to** use Git SSH sources; cocoapods, however, produces warnings about it, stopping
pod repo push
with validation errors. Thus, I (and all the team members) always adds--allow-warnings
inpod repo push
.I think it is too strict that a Git SSH URL is regarded as invalid by default. Can you please remove this warning, or make it just a notice instead of validation errors?
The text was updated successfully, but these errors were encountered: