Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a Project#dirty? method #202

Closed
alloy opened this issue Oct 7, 2014 · 6 comments
Closed

Add a Project#dirty? method #202

alloy opened this issue Oct 7, 2014 · 6 comments

Comments

@alloy
Copy link
Member

alloy commented Oct 7, 2014

This should return whether or not any changes have been made to the project since it was loaded from disk.

It would remove the need for most/all of these changes CocoaPods/CocoaPods#2606.

/cc @segiddins

@neonichu
Copy link
Member

neonichu commented Oct 7, 2014

I'd say once #199 is implemented, we can just save whenever we want, just like Xcode does :)

@alloy
Copy link
Member Author

alloy commented Oct 7, 2014

@neonichu Good point. I guess I’m just a little conservative and wouldn’t want the project to unnecessarily get saved in situations where we fallback to normal CFPropertyList handling (when Xcode can’t be located or the frameworks can’t be loaded).

@kylef
Copy link
Contributor

kylef commented Oct 7, 2014

@neonichu We shouldn't save all the time, only when changed. Stop harming my SSD write cycles you!

@neonichu
Copy link
Member

neonichu commented Oct 7, 2014

@kylef I hope you never use Xcode to work with your project, then :)

@alloy
Copy link
Member Author

alloy commented Oct 7, 2014

work

LOL

@kylef
Copy link
Contributor

kylef commented Oct 15, 2014

When this work is done, be sure to refactor CocoaPods to make use of it: CocoaPods/CocoaPods@81f85e0#diff-7dd6f660fb1a2603c42ffb5de8c97297R30

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants