Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cocoapods-downloader does not support http downloads where url contains get params #15

Closed
sglist opened this issue Apr 7, 2014 · 1 comment

Comments

@sglist
Copy link

sglist commented Apr 7, 2014

  1. Create a podspec where s.source contains a url with get params. For example:s.source = { :http => 'http://example.com/1/2?x=1&artifact=file.zip' }
  2. Run pod install

Result: source fails to download

Installing MyPod (1.0.0)
[!] Pod::Executable -L -o /Users/user/MyPod/file.zip http://example.com/1/2?x=1&artifact=file.zip --create-dirs

sh: --create-dirs: command not found

  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current

                                 Dload  Upload   Total   Spent    Left  Speed

100   708    0   708    0     0   5149      0 --:--:-- --:--:-- --:--:--  5167

Note: This could be fixed by quoting the url passed to curl:
https://github.com/CocoaPods/cocoapods-downloader/blob/master/lib/cocoapods-downloader/http.rb#L87

  def download_file(full_filename)
    curl! %|-L -o #{full_filename.shellescape} "#{url}" --create-dirs|
  end
@fabiopelosin
Copy link
Member

The fix would be similar to this: 7b0e373

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants