Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Task for v3 #59

Closed
5 tasks done
Code-Hex opened this issue Oct 8, 2022 · 7 comments · Fixed by #95 or #108
Closed
5 tasks done

Task for v3 #59

Code-Hex opened this issue Oct 8, 2022 · 7 comments · Fixed by #95 or #108
Labels
enhancement New feature or request

Comments

@Code-Hex
Copy link
Owner

Code-Hex commented Oct 8, 2022 •
edited
Loading

This library had some build issues between macOS versions. (See: #41)
So I decided to introduce some breaking changes and I will add some test code to improve reliabilities.

Tasks to release v3.

Welcome your creating issues but I'm not welcome your PR to change major code.
@Code-Hex Code-Hex added the enhancement New feature or request label Oct 8, 2022
@Code-Hex Code-Hex pinned this issue Oct 8, 2022
@Code-Hex Code-Hex mentioned this issue Oct 10, 2022
Closed
@cfergeau
Copy link
Contributor

See #54 (comment) for one potential API removal before v3

This was referenced Oct 12, 2022
Merged
Merged
@Code-Hex
Copy link
Owner Author

Perhaps the #42 issue could be addressed after v3 is released. (so that compatibility can be maintained)

@cfergeau
Copy link
Contributor

Adding new API should be ok from a go compatibility perspective. I agree it can probably be addressed after v3

@Code-Hex
Copy link
Owner Author

Code-Hex commented Oct 30, 2022 •
edited
Loading

@Code-Hex
Copy link
Owner Author

I think I can release v3 in next week

@balajiv113
Copy link
Contributor

balajiv113 commented Oct 30, 2022 •
edited by Code-Hex
Loading

Might need to add support for this as well

@Code-Hex Code-Hex mentioned this issue Oct 31, 2022
Merged
@Code-Hex Code-Hex reopened this Oct 31, 2022
This was referenced Oct 31, 2022
Merged
Merged
@Code-Hex
Copy link
Owner Author

Code-Hex commented Nov 2, 2022

I will release v3 after editing the README.

@Code-Hex Code-Hex mentioned this issue Nov 2, 2022
Merged
@Code-Hex Code-Hex unpinned this issue Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

added macOS 13 mtu API for FileHandleNetworkDeviceAttachment Code-Hex/vz
v3 Code-Hex/vz
3 participants
@cfergeau @Code-Hex @balajiv113