Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Current Line Highlight #34

Closed
austincondiff opened this issue Mar 23, 2022 · 6 comments
Closed

✨ Current Line Highlight #34

austincondiff opened this issue Mar 23, 2022 · 6 comments
Labels
enhancement New feature or request

Comments

@austincondiff
Copy link
Collaborator

Current line needs to be highlighted and current line number is primary text color.

image

@austincondiff austincondiff added the enhancement New feature or request label Mar 23, 2022
@austincondiff austincondiff changed the title [FEAT] - Current Line Highlight ✨ Current Line Highlight Mar 31, 2022
@stale stale bot added the wontfix This will not be worked on label May 30, 2022
@CodeEditApp CodeEditApp deleted a comment from stale bot Jun 1, 2022
@stale stale bot removed the wontfix This will not be worked on label Jun 1, 2022
@austincondiff austincondiff transferred this issue from CodeEditApp/CodeEdit Jun 24, 2022
@NakaokaRei
Copy link

@austincondiff
I want to work on this issue!
Can you please assign it to me?

@austincondiff
Copy link
Collaborator Author

austincondiff commented Oct 3, 2022

Sure thing! One thing to note, the top line is highlighted in this screenshot, so it is working however there are two things that need to happen here.

  1. The highlight needs to extend into the gutter. And the separator needs to be removed.
  2. The line number needs to be more prominent (and other line numbers less prominent).

image

We are trying to make it look like this (code folding will come later)...

image

One thing to consider is it might have something to do with STTextView so you may need to submit a PR over there as well.

To get rid of the separator, we need to do the following in STTextViewController.swift...

- rulerView.separatorColor = theme.invisibles
+ rulerView.drawSeparator = false

@NakaokaRei
Copy link

@austincondiff
Thank you for the advice!
I will investigate and report back if I have to change STTextView 🙇

@NakaokaRei
Copy link

@austincondiff
As far as you can tell, as you are talking about, it doesn't look like I can tackle this issue without changing STTextView.
This is difficult for me and I have no prospects for development, so I will remove the assign for now.
Sorry 🙇

I think this CodeEdit is a great project and I'll comment as soon as I find an issue I can do myself!

@NakaokaRei NakaokaRei removed their assignment Oct 4, 2022
@austincondiff austincondiff moved this from In Progress to Todo in CodeEdit Project Oct 12, 2022
@Eliulm
Copy link
Contributor

Eliulm commented Jan 3, 2023

I am currently finalizing my pull request for the STTextView repository. With that, we can add line highlighting, just like in Xcode.

@austincondiff
Copy link
Collaborator Author

Closing this as the line highlight has been implemented.

@github-project-automation github-project-automation bot moved this from Todo to Done in CodeEdit Project Jan 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: 🏁 Complete
Development

No branches or pull requests

3 participants