Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve social sharing in CKAN #3

Merged
merged 10 commits into from
Sep 18, 2017

Conversation

edmondatto
Copy link
Contributor

@edmondatto edmondatto commented Sep 18, 2017

Fixes #1 and #2

Proposed fixes:

Features:

  • includes tests covering changes
  • includes updated documentation
  • includes user-visible changes
  • includes API changes
  • includes bugfix for possible backport

Please [X] all the boxes above that apply

@DavidLemayian
Copy link
Contributor

This is looking good @edmondatto. Could you create some more Github Issues on the remaining features? We'll commit to master for now until we have the basics nailed down.

@DavidLemayian DavidLemayian merged commit c1435d6 into CodeForAfrica:master Sep 18, 2017
@edmondatto
Copy link
Contributor Author

@DavidLemayian Could you clarify on the remaining features? Also, the PR you merged fixes both issues ( #1 & #2) Shouldn't they both be closed?

@DavidLemayian
Copy link
Contributor

Hi @edmondatto. Don't know how I missed your ping here. I've just made significant architecture changes to the code following how ckan and others structure their directory structures.

For clarification of remaining features: it's the unit tests, API changes, and bug fixes for back ports that you've listed in the PR description. We should create Github issues in relation to these.

As for closing the issues, they'd remain open until we have tests done so that we can reference the features we are testing for. (Note that the use of word "features" here is not the same as the sentence before this)

@edmondatto edmondatto deleted the develop branch October 3, 2017 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve previews/cards by adding open graph tags in head
4 participants