-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve social sharing in CKAN #3
Conversation
…s and twitter tags for twitter
…into develop Merging upstream changes into local branch
…into develop Merge upstream changes to local
This is looking good @edmondatto. Could you create some more Github Issues on the remaining features? We'll commit to |
@DavidLemayian Could you clarify on the remaining features? Also, the PR you merged fixes both issues ( #1 & #2) Shouldn't they both be closed? |
Hi @edmondatto. Don't know how I missed your ping here. I've just made significant architecture changes to the code following how ckan and others structure their directory structures. For clarification of remaining features: it's the unit tests, API changes, and bug fixes for back ports that you've listed in the PR description. We should create Github issues in relation to these. As for closing the issues, they'd remain open until we have tests done so that we can reference the features we are testing for. (Note that the use of word "features" here is not the same as the sentence before this) |
Fixes #1 and #2
Proposed fixes:
Features:
Please [X] all the boxes above that apply