-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Laravel 5.5 Support #186
Comments
I've also opened an issue related to this here: laravel/framework#20902 |
Looks like this needs to be fixed in the package, removing the |
I solved this problem in my own 'Stapler copycat' package this way: So far, so good, but if anyone has a nicer fix, I'd love to hear it. |
@czim Solid fix, thank you for sharing! I ended up using my own trait (which uses the EloquentTrait) to override the |
This change is not backwards compatible with this package. This is due to the override of the
getAttributes()
model method. If the attribute values aren't strings, the query builder can't bind them properly and you get an "Object could not be converted to string" message.This looks like it's been in the EloquentTrait for quite a long time, since 86fd1db. What does overriding that method actually provide though? Doesn't the accessor for the field still exist?
Edit: Sorry I didn't bring this issue up in the laravel stapler repo, but this is the repo that contains the EloquentTrait class
The text was updated successfully, but these errors were encountered: