Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

:attachment interpolation & updates to Inflector pluralization #194

Open
ccwittwer opened this issue Jul 23, 2018 · 0 comments
Open

:attachment interpolation & updates to Inflector pluralization #194

ccwittwer opened this issue Jul 23, 2018 · 0 comments

Comments

@ccwittwer
Copy link

A consideration for a future update might be to stop using Inflector pluralization on :attachment interpolation when creating the location for files. The Inflector package is routinely getting updates to how certain words are pluralized and when those updates are pulled into a project with Stapler, it can change Stapler's construction of file locations.

For example, a project with an attachment named "audio" was formerly stored in /audios/[id]/[style]/[filename], but in Inflector v1.3, the pluralization for "audio" was changed to "audio" (instead of "audios"), which resulted in Stapler expecting files to be located at /audio/[id]/[style]/[filename]; breaking the connection to those files.

It may be a better approach to interpolate :attachment with the attachment name as specified on the model, rather than pluralizing it. And/or allow for the plural form to be specified on the model.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant