Skip to content
This repository was archived by the owner on Apr 18, 2025. It is now read-only.

Commit ff69c3b

Browse files
authored
Merge pull request #24 from CodeYourFuture/update-review-guides
Update review and help guidance markdowns
2 parents 7725a55 + 4b8dd74 commit ff69c3b

File tree

4 files changed

+8
-70
lines changed

4 files changed

+8
-70
lines changed

.github/pull_request_template.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,11 +2,11 @@
22
33
You must title your PR like this:
44
5-
COHORT_NAME | FIRST_NAME LAST_NAME | REPO_NAME
5+
COHORT_NAME | FIRST_NAME LAST_NAME | REPO_NAME | WEEK
66
77
For example,
88
9-
NW4 | Carol Owen | HTML-CSS-Coursework-Week1
9+
NW4 | Carol Owen | HTML-CSS-Module | Week1
1010
1111
Complete the task list below this message.
1212
If your PR is rejected, check the task list.
@@ -18,7 +18,7 @@ If your PR is rejected, check the task list.
1818
Self checklist
1919

2020
- [ ] I have committed my files one by one, on purpose, and for a reason
21-
- [ ] I have titled my PR with COHORT_NAME | FIRST_NAME LAST_NAME | REPO_NAME
21+
- [ ] I have titled my PR with COHORT_NAME | FIRST_NAME LAST_NAME | REPO_NAME | WEEK
2222
- [ ] I have tested my changes
2323
- [ ] My changes follow the [style guide](https://syllabus.codeyourfuture.io/guides/code-style-guide/)
2424
- [ ] My changes meet the [requirements](./README.md) of this task

HOW-TO-GET-HELP.md

Lines changed: 0 additions & 46 deletions
This file was deleted.

HOW_TO_REVIEW.md

Lines changed: 4 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,7 @@
11
<!--
22
Do not edit this file.
33
Make a change to the template and then pull changes
4-
Repo: https://github.com/CodeYourFuture/CYF-Coursework-Template
5-
Update Instructions: https://gist.github.com/ChrisOwen101/84d82f03a60ce19f7f154a7b815fa265
4+
Repo: https://github.com/CodeYourFuture/Module-Template
65
-->
76

87
# Everyone reviews code at CYF
@@ -36,25 +35,11 @@ Reviewers, please add labels (provided) to the PR once you've reviewed. This hel
3635

3736
### Where to find solutions?
3837

39-
Add `-Solution` to the end of a repo url to find the solution.
38+
You can find the solutions for the module on the `solutions` branch.
4039

41-
For this repo:
40+
### Solutions branch
4241

43-
https://github.com/CodeYourFuture/JavaScript-Core-1-Coursework-Week1
44-
45-
Find the solution here:
46-
47-
https://github.com/CodeYourFuture/JavaScript-Core-1-Coursework-Week1-Solution
48-
49-
**_If you get a 404_**
50-
51-
**Mentors:** Join your Github Team - ask in Slack or look in the pinned posts in the top of your channel.
52-
53-
**Trainees** get solution repos one week later. Ask your mentors in Slack if you are getting a 404.
54-
55-
### Using the Solutions Repo
56-
57-
Solutions repo typically contain:
42+
The solutions branch typically contains:
5843

5944
#### Sample solutions
6045

HOW-TO-SUBMIT.md renamed to contributing.md

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,7 @@
11
<!--
22
Do not edit this file.
33
Make a change to the template and then pull changes
4-
Repo: https://github.com/CodeYourFuture/CYF-Coursework-Template
5-
Update Instructions: https://gist.github.com/ChrisOwen101/84d82f03a60ce19f7f154a7b815fa265
4+
Repo: https://github.com/CodeYourFuture/Module-Template
65
-->
76

87
# How To Submit Your Coursework

0 commit comments

Comments
 (0)