Skip to content

Commit 66fa83d

Browse files
committed
Small changes according to review.
1 parent eea88c3 commit 66fa83d

File tree

3 files changed

+6
-6
lines changed

3 files changed

+6
-6
lines changed

Sprint-1/1-key-exercises/2-initials.js

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,7 @@ let lastName = "Johnson";
55
// Declare a variable called initials that stores the first character of each string.
66
// This should produce the string "CKJ", but you must not write the characters C, K, or J in the code of your solution.
77

8-
//let initials = `${firstName.charAt(0)}+${middleName.charAt(0)}+${lastName.charAt(0)}}`;
9-
let initials = `${firstName.charAt(0)+middleName.charAt(0)+lastName.charAt(0)}`;
8+
let initials = firstName.charAt(0)+middleName.charAt(0)+lastName.charAt(0);
109
console.log(`The initials are: ${initials}`)
1110

1211
// https://www.google.com/search?q=get+first+character+of+string+mdn

Sprint-1/2-mandatory-errors/4.js

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
const 12HourClockTime = "20:53";
2+
//twelveHourClockTime
23
const 24hourClockTime = "08:53";
3-
4-
//Explenation: the name of value in JS can not start with numbers.
4+
//twentyFourHourClockTime
5+
//Explanation: the name of value in JS can not start with numbers.

Sprint-1/3-mandatory-interpret/2-time-format.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,8 +21,8 @@ console.log(result);
2121
// %-this is remaider operator that help us get remaining. In this case, dividing MovieLength % 60 returned
2222
// remainder. It is not a typical mathematic division, it is division where we can get remainder.
2323
// d) Interpret line 4, what does the expression assigned to totalMinutes mean?
24-
// Mean the subtraction remaider(second) from the total length (in second) and divide by 60, because we need Minutes (1 min = 60 sec)
24+
// Means the subtraction remaider(second) from the total length (in second) and divide by 60, because we need Minutes (1 min = 60 sec)
2525
// e) What do you think the variable result represents? Can you think of a better name for this variable?
26-
//time
26+
//FormattedMovieTime
2727
// f) Try experimenting with different values of movieLength. Will this code work for all values of movieLength? Explain your answer
2828
//It works with a different values(negative and positive numbers).

0 commit comments

Comments
 (0)