Address the issues from the pull request comments

Author: anosidium

Sprint-3/1-implement-and-rewrite-tests/implement/2-is-proper-fraction.js

@@ -8,11 +8,11 @@
 // write one test at a time, and make it pass, build your solution up methodically
 
 function isProperFraction(numerator, denominator) {
-  if (numerator < denominator) {
-    return true;
-  } else {
+  if (denominator === 0) {
     return false;
   }
+
+  return Math.abs(numerator) < Math.abs(denominator);
 }
 
 // The line below allows us to load the isProperFraction function into tests in other files.
@@ -59,3 +59,9 @@ assertEquals(equalFraction, false);
 
 // Stretch:
 // What other scenarios could you test for?
+
+const divideByZero = isProperFraction(3, 0);
+assertEquals(divideByZero, false);
+
+const zeroNumerator = isProperFraction(0, 3);
+assertEquals(zeroNumerator, true);

Sprint-3/1-implement-and-rewrite-tests/implement/3-get-card-value.js

@@ -8,13 +8,13 @@
 // write one test at a time, and make it pass, build your solution up methodically
 // just make one change at a time -- don't rush -- programmers are deep and careful thinkers
 function getCardValue(card) {
-  const rank = card[0];
+  const rank = card.slice(0, -1);
 
   if (rank === "A") {
     return 11;
   } else if (["J", "Q", "K"].includes(rank)) {
     return 10;
-  } else if (rank >= 2 || rank <= 10) {
+  } else if (!isNaN(rank) && Number(rank) >= 2 && Number(rank) <= 10) {
     return Number(rank);
   } else {
     return "Invalid card rank.";

Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/2-is-proper-fraction.test.js

@@ -7,15 +7,23 @@ test("should return true for a proper fraction", () => {
 });
 
 // Case 2: Identify Improper Fractions:
-test("should return false for an import fraction", () => {
+test("should return false for an improper fraction", () => {
   expect(isProperFraction(3, 2)).toEqual(false);
 });
 
+test("should return false for an improper fraction", () => {
+  expect(isProperFraction(-5, 3)).toEqual(false);
+});
+
 // Case 3: Identify Negative Fractions:
 test("should return true for a negative fraction", () => {
   expect(isProperFraction(-4, 7)).toEqual(true);
 });
 
+test("should return true for a negative fraction", () => {
+  expect(isProperFraction(4, -7)).toEqual(true);
+});
+
 // Case 4: Identify Equal Numerator and Denominator:
 test("should return false for a fraction whose numerator and denominator are the same", () => {
   expect(isProperFraction(3, 3)).toEqual(false);

Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/3-get-card-value.test.js

@@ -8,20 +8,26 @@ test("should return 11 for Ace of Spades", () => {
 });
 
 // Case 2: Handle Number Cards (2-10):
-test("should return 5 for a number card", () => {
-  const fiveofHearts = getCardValue("5♥");
-  expect(fiveofHearts).toEqual(5);
-});
+for (let i = 2; i <= 10; i++) {
+  test(`should return ${i} for a number card ${i}♥`, () => {
+    const card = getCardValue(`${i}♥`);
+    expect(card).toEqual(i);
+  });
+}
 
 // Case 3: Handle Face Cards (J, Q, K):
-test("should return 10 for a face card", () => {
-  const jackOfDiamonds = getCardValue("J♢");
-  expect(jackOfDiamonds).toEqual(10);
-});
+const faceCards = ["J", "Q", "K"];
+
+for (let faceCard of faceCards) {
+  test(`should return 10 for a card card ${faceCard}♢`, () => {
+    const card = getCardValue(`${faceCard}♢`);
+    expect(card).toEqual(10);
+  });
+}
 
 // Case 4: Handle Ace (A):
 test("should return 11 for an Ace", () => {
-  const ace = getCardValue("A");
+  const ace = getCardValue("A♠");
   expect(ace).toEqual(11);
 });