Skip to content

Commit 09e64fd

Browse files
committed
Make todos standard for base2
1 parent aceca87 commit 09e64fd

File tree

4 files changed

+8
-44
lines changed

4 files changed

+8
-44
lines changed

.agents/base2/base2-fast-todos.ts

Lines changed: 0 additions & 8 deletions
This file was deleted.

.agents/base2/base2-fast-with-decomposing-thinker.ts

Lines changed: 0 additions & 11 deletions
This file was deleted.

.agents/base2/base2-gpt-5-worker.ts

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -27,13 +27,11 @@ const definition: SecretAgentDefinition = {
2727
2828
The user asks you to implement a new feature. You respond in multiple steps:
2929
30-
1. Spawn two different file-picker-max's with different prompts to find relevant files; spawn a code-searcher and glob-matcher to find more relevant files and answer questions about the codebase; spawn 1 docs researcher to find relevant docs.
31-
1a. Read all the relevant files using the read_files tool.
32-
2. Spawn one more file-picker-max and one more code-searcher with different prompts to find relevant files.
33-
2a. Read all the relevant files using the read_files tool.
34-
3. Use the str_replace or write_file tool to make the changes.
35-
4. Test your changes by running appropriate validation commands for the project (e.g. typechecks, tests, lints, etc.). You may have to explore the project to find the appropriate commands.
36-
5. End your turn.`,
30+
- Gather context on the user's request
31+
- Use the write_todos tool to write out your step-by-step implementation plan.
32+
- Use the str_replace or write_file tool to make the changes.
33+
- Test your changes by running appropriate validation commands for the project (e.g. typechecks, tests, lints, etc.). You may have to explore the project to find the appropriate commands.
34+
- End your turn.`,
3735

3836
stepPrompt: undefined,
3937
}

.agents/base2/base2.ts

Lines changed: 3 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -10,15 +10,9 @@ export const createBase2: (
1010
mode: 'fast' | 'max',
1111
options?: {
1212
hasNoValidation?: boolean
13-
hasDecomposingThinker?: boolean
14-
usesTodos?: boolean
1513
},
1614
) => Omit<SecretAgentDefinition, 'id'> = (mode, options) => {
17-
const {
18-
hasNoValidation = false,
19-
hasDecomposingThinker = false,
20-
usesTodos = false,
21-
} = options ?? {}
15+
const { hasNoValidation = false } = options ?? {}
2216
const isFast = mode === 'fast'
2317
const isMax = mode === 'max'
2418

@@ -49,7 +43,7 @@ export const createBase2: (
4943
'spawn_agents',
5044
isMax && 'spawn_agent_inline',
5145
'read_files',
52-
usesTodos && 'write_todos',
46+
'write_todos',
5347
'str_replace',
5448
'write_file',
5549
),
@@ -61,7 +55,6 @@ export const createBase2: (
6155
'glob-matcher',
6256
'researcher-web',
6357
'researcher-docs',
64-
hasDecomposingThinker && 'decomposing-thinker',
6558
'commander',
6659
isMax && 'base2-gpt-5-worker',
6760
'context-pruner',
@@ -82,8 +75,6 @@ Continue to spawn layers of agents until have completed the user's request or re
8275
- **Sequence agents properly:** Keep in mind dependencies when spawning different agents. Don't spawn agents in parallel that depend on each other. Be conservative sequencing agents so they can build on each other's insights:
8376
- Spawn file pickers, code-searcher, directory-lister, glob-matcher, commanders, and researchers before making edits.
8477
${buildArray(
85-
hasDecomposingThinker &&
86-
'- Spawn a decomposing-thinker agent after you have gathered all the context to ask key questions and plan your response. Make sure to include all the relevant file paths in the params.',
8778
isMax &&
8879
'- Spawn a base2-gpt-5-worker agent inline after you have gathered all the context you need (and not before!).',
8980
).join('\n ')}
@@ -152,13 +143,7 @@ ${buildArray(
152143
'- You must spawn a file-researcher to find relevant files; consider also spawning a web and/or docs researcher to find relevant information online.',
153144
'- Read **ALL** the files that the file-researcher found using the read_files tool. It is important that you read every single file that the file-researcher found. This is the only time you should use read_files on a long list of files -- it is expensive to do this more than once!',
154145
`- Consider spawning other agents or reading more files as needed to gather comprehensive context to answer the user's request.`,
155-
hasDecomposingThinker &&
156-
`- Spawn a decomposing-thinker agent to ask key questions and plan your response. Make sure to include all the relevant file paths in the params.`,
157-
usesTodos &&
158-
`- Use the write_todos tool to write out your step-by-step implementation plan.${hasNoValidation ? '' : ' You should include at least one step to validate/test your changes.'}`,
159-
isFast &&
160-
!usesTodos &&
161-
'- Write out your implementation plan as a bullet point list.',
146+
isFast && `- Use the write_todos tool to write out your step-by-step implementation plan.${hasNoValidation ? '' : ' You should include at least one step to validate/test your changes.'}`,
162147
isFast &&
163148
`- Use the str_replace or write_file tool to make the changes. (Pause after making all the changes to see the tool results of your edits and double check they went through correctly.)`,
164149
isMax &&

0 commit comments

Comments
 (0)