In max mode, do typecheck before code review

Author: jahooma

agents/base2/base2.ts

@@ -205,9 +205,11 @@ ${
 }
 
 ${
-  isDefault || isMax
-    ? `[ You spawn a ${isDefault ? 'code-reviewer' : 'code-reviewer-multi-prompt'}, a commander to typecheck the changes, and another commander to run tests, all in parallel ]`
-    : '[ You spawn a commander to typecheck the changes and another commander to run tests, all in parallel ]'
+  isDefault
+    ? `[ You spawn a code-reviewer, a commander to typecheck the changes, and another commander to run tests, all in parallel ]`
+    : isMax
+      ? `[  You spawn a commander to typecheck the changes, and another commander to run tests, in parallel. Then, you spawn a code-reviewer-multi-prompt to review the changes. ]`
+      : '[ You spawn a commander to typecheck the changes and another commander to run tests, all in parallel ]'
 }
 
 ${
@@ -331,10 +333,10 @@ ${buildArray(
     '- Implement the changes using the str_replace or write_file tools. Implement all the changes in one go.',
   isFast &&
     '- Do a single typecheck targeted for your changes at most (if applicable for the project). Or skip this step if the change was small.',
-  (isDefault || isMax) &&
-    `- Spawn a ${isDefault ? 'code-reviewer' : 'code-reviewer-multi-prompt'} to review the changes after you have implemented the changes. (Skip this step only if the change is extremely straightforward and obvious.)`,
   !hasNoValidation &&
     `- For non-trivial changes, test them by running appropriate validation commands for the project (e.g. typechecks, tests, lints, etc.). Try to run all appropriate commands in parallel. ${isMax ? ' Typecheck and test the specific area of the project that you are editing *AND* then typecheck and test the entire project if necessary.' : ' If you can, only test the area of the project that you are editing, rather than the entire project.'} You may have to explore the project to find the appropriate commands. Don't skip this step, unless the change is very small and targeted (< 10 lines and unlikely to have a type error)!`,
+  (isDefault || isMax) &&
+    `- Spawn a ${isDefault ? 'code-reviewer' : 'code-reviewer-multi-prompt'} to review the changes after you have implemented changes. (Skip this step only if the change is extremely straightforward and obvious.)`,
   `- Inform the user that you have completed the task in one sentence or a few short bullet points.${isSonnet ? " Don't create any markdown summary files or example documentation files, unless asked by the user." : ''}`,
   !isFast &&
     !noAskUser &&