feat: allow symfony 8 #47
Conversation
| } | ||
|
|
||
| protected function doRequest(object $request) | ||
| protected function doRequest(object $request): object |
There was a problem hiding this comment.
The return type was added because it was added in symfony/browser-kit v8 as well.
This change could be considered a BC break.
The class is not final and thus users might get a type error if they extended this class and used a different return type.
@TavoNiievez @SamMousa What's your opinion here? Should this change be considered a BC break and thus result in a new major release?
There was a problem hiding this comment.
I just noticed that #37 added some return type hints to some methods as well without tagging a new major version. The changes were part of the bugfix release 3.0.2.
Maybe it is okay to accept the BC break of my PR without tagging a new major version?
There was a problem hiding this comment.
I'm not sure how major releases in repositories that have automated releases configured actually work.
I probably skipped checking whether this should be released as a minor or major change when I saw that the process was automated.
IMO, we should treat the release of this version as it was labeled as a mistake.
We should stick to semver as much as possible.
But I'll leave the final word to @SamMousa since he's a little more familiar with it.
There was a problem hiding this comment.
According to the docs to add "BREAKING CHANGE:" to the footer of the commit message.
Adjusting the commit message worked like a charm and https://github.com/Codeception/module-phpbrowser/releases/tag/4.0.0 was successfully released.
BREAKING CHANGE: The native object return type was added to the doRequest() method of the Guzzle connector. That might break code extending from this class.
|
🎉 This PR is included in version 4.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
2 participants
fixes #46