-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Neve FSE Landing Page Themeisle #24
Comments
A good start would be to clone Raft page, @preda-bogdan; and from there we can all colaborate there, design team with screenshots and layout, Harshit with text and you with implementing more complex things. In terms of Content @harshitarora-in , it will probably be pretty much the same ideas as we have for other FSE themes; the difference here will be presenting how we adapted some of the features from Neve to Neve FSE, basically letting users know the 'soul' of Neve is still here :) |
Yeah, good idea. @mghenciu @harshitarora-in I have created a figma page that we can use for some creative brainstorming before applying to the actual page. |
@JohnPixle @mghenciu and @harshitarora-in I've added a page here https://fmbklha76y-staging.onrocket.site/themes/neve-fse/ that is a duplicate of the Raft page that we can use before adding to production. Let me know when I can start adding the design. |
Thanks for the heads up, I will start working on the copywriting part and will notify here once I am done! |
@harshitarora-in you also have edit privileges in Figma, in this page. Feel free to add / edit as you see fit. If you have issues with the font, you can share the text and I will update the figma. |
@JohnPixle Yes I made some text edits yesterday and you are right I was having some issues with the font so I replaced the font with SF Pro, is that okay? |
I have edited the content as well as one screenshot in the Figma design, please do let me know your feedback. Thank you! |
@harshitarora-in |
I think the overall layout and copy from Figma are ready, Bogdan. |
@preda-bogdan , just a quick question, when you have some time. Easy translationElements in this theme can be translated with free and premium plugins. Plus, you can use any RTL language. we are not overpromising something? I mean that the theme will work with Translation and RTL plugins. Can you please confirm? |
@mghenciu Yes, we are using the i18n translation functions for the texts as it is required for any theme and plugin. However there are some texts inside the Let me know if this clears things up. In my opinion it should be fine. |
@Codeinwp/design-team Let me know if you have any feedback. |
@preda-bogdan Great work! Everything looks good to me. Just found a minor issue, here is the reference: https://vertis.d.pr/i/CPIRfb I also believe that we can reduce spacing between the sections, https://vertis.d.pr/i/g0er2J |
@harshitarora-in I've updated the spacing and fixed the alignment issue, Thank you for mentioning it. |
@preda-bogdan looking good, thank you for the update. I see you have some spacer blocks of 200px before and after the templates-related image, which results in excessive spacing between the sections. I removed both the spacer blocks (above and below) and it is looking a bit better, think we can remove those spacers safely? |
Sorry, I just saw Harshit also mentioned the spacing issue, please disregard if already fixed 👍🏻 |
@JohnPixle I've reduced the spacers to 100px, from 200px. You can let me know if it looks ok, I added them to resemble the design spacing, removing them entirely is also an option but the sections might be too close together. |
@mghenciu Thank you, I've updated the image. |
@preda-bogdan Spacing is fine now as it is, thanks for taking care of it 👍🏻 |
@preda-bogdan One final thing regarding this. I believe we'll need a demosites.io/neve-fse site, where we can add the fse theme and build a proper demo. (instead of the testing site we now have at https://fse-neve.vertisite.cloud/ Also, the "view demo" button should link to the demosites site. Think you can create a new domain and upload the theme build? |
@JohnPixle I've already did this for staging https://staging.demosites.io/neve-fse/ and will replicate it on live just for this purpose. |
Awesome, thanks!! 🚀 |
@preda-bogdan not sure if you've already saw this, but on mobile, there is some big spacing in this section https://vertis.d.pr/i/fo3fGX and the content here https://vertis.d.pr/i/Yq0OER does not have left/right space |
@rodica-andronache Thank you for mentioning this, I've solved it on live. I am awaiting for some changes to be merged to Themeisle and will publish the page. 👍🏼 |
To prepare for the launch we need to also have the Neve FSE landing page ready on the Themeisle website.
I can copy one of the pages from our other FSE themes as a base, maybe Raft.
@Codeinwp/design-team Can you help with some guidance here?
@harshitarora-in I'm adding you to the loop for the copyright part.
Let me know your input we can have everything ready by the end of next week I think.
Figma
The text was updated successfully, but these errors were encountered: