Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Neve FSE Landing Page Themeisle #24

Closed
preda-bogdan opened this issue Apr 27, 2023 · 25 comments
Closed

Neve FSE Landing Page Themeisle #24

preda-bogdan opened this issue Apr 27, 2023 · 25 comments
Assignees
Labels
new feature Request for a new feature or functionality to be added to the project. small (1-3h) This label is used for issues that can be completed within 3 hours or less.

Comments

@preda-bogdan
Copy link
Contributor

preda-bogdan commented Apr 27, 2023

To prepare for the launch we need to also have the Neve FSE landing page ready on the Themeisle website.

I can copy one of the pages from our other FSE themes as a base, maybe Raft.

@Codeinwp/design-team Can you help with some guidance here?

@harshitarora-in I'm adding you to the loop for the copyright part.

Let me know your input we can have everything ready by the end of next week I think.


Figma

@preda-bogdan preda-bogdan added the new feature Request for a new feature or functionality to be added to the project. label Apr 27, 2023
@preda-bogdan preda-bogdan self-assigned this Apr 27, 2023
@mghenciu
Copy link
Contributor

A good start would be to clone Raft page, @preda-bogdan; and from there we can all colaborate there, design team with screenshots and layout, Harshit with text and you with implementing more complex things.

In terms of Content @harshitarora-in , it will probably be pretty much the same ideas as we have for other FSE themes; the difference here will be presenting how we adapted some of the features from Neve to Neve FSE, basically letting users know the 'soul' of Neve is still here :)

@JohnPixle
Copy link
Contributor

Yeah, good idea. @mghenciu @harshitarora-in I have created a figma page that we can use for some creative brainstorming before applying to the actual page.

@preda-bogdan preda-bogdan added the small (1-3h) This label is used for issues that can be completed within 3 hours or less. label Apr 28, 2023
@preda-bogdan
Copy link
Contributor Author

preda-bogdan commented Apr 28, 2023

@JohnPixle @mghenciu and @harshitarora-in I've added a page here https://fmbklha76y-staging.onrocket.site/themes/neve-fse/ that is a duplicate of the Raft page that we can use before adding to production.

Let me know when I can start adding the design.

@harshitarora-in
Copy link

In terms of Content @harshitarora-in , it will probably be pretty much the same ideas as we have for other FSE themes; the difference here will be presenting how we adapted some of the features from Neve to Neve FSE, basically letting users know the 'soul' of Neve is still here :)

Thanks for the heads up, I will start working on the copywriting part and will notify here once I am done!

@JohnPixle
Copy link
Contributor

@harshitarora-in you also have edit privileges in Figma, in this page.

Feel free to add / edit as you see fit. If you have issues with the font, you can share the text and I will update the figma.

Screenshot 2023-05-02 at 10 56 28 AM

@harshitarora-in
Copy link

@JohnPixle Yes I made some text edits yesterday and you are right I was having some issues with the font so I replaced the font with SF Pro, is that okay?

@harshitarora-in
Copy link

I have edited the content as well as one screenshot in the Figma design, please do let me know your feedback.

Thank you!

@preda-bogdan
Copy link
Contributor Author

@harshitarora-in
cc: @JohnPixle
Is this ready to be added to staging and live? Are there any changes required here?

@mghenciu
Copy link
Contributor

mghenciu commented May 3, 2023

I think the overall layout and copy from Figma are ready, Bogdan.
Later, we may need to do some minor text changes, but after the page is live/draft on Themeisle site - I can do those changes myself.

@mghenciu
Copy link
Contributor

mghenciu commented May 4, 2023

@preda-bogdan , just a quick question, when you have some time.
We were discussing with Harshit about the text on the Landing Page, and wanted to ask if with this line:

Easy translation

Elements in this theme can be translated with free and premium plugins. Plus, you can use any RTL language.
Screenshot 2023-05-04 at 13 00 19

we are not overpromising something? I mean that the theme will work with Translation and RTL plugins. Can you please confirm?

@preda-bogdan
Copy link
Contributor Author

@mghenciu Yes, we are using the i18n translation functions for the texts as it is required for any theme and plugin. However there are some texts inside the html files that are not translatable. But since they are part of the content it should be fine as plugins that allow content translation would work as expected.

Let me know if this clears things up. In my opinion it should be fine.
Thank you!

@preda-bogdan
Copy link
Contributor Author

@Codeinwp/design-team
cc; @harshitarora-in
I've included the design and text changes here: https://fmbklha76y-staging.onrocket.site/themes/neve-fse/

Let me know if you have any feedback.
Thank you!

@harshitarora-in
Copy link

@preda-bogdan Great work! Everything looks good to me.

Just found a minor issue, here is the reference: https://vertis.d.pr/i/CPIRfb

I also believe that we can reduce spacing between the sections, https://vertis.d.pr/i/g0er2J

@preda-bogdan
Copy link
Contributor Author

preda-bogdan commented May 4, 2023

@harshitarora-in I've updated the spacing and fixed the alignment issue, Thank you for mentioning it.

@JohnPixle
Copy link
Contributor

@preda-bogdan looking good, thank you for the update. I see you have some spacer blocks of 200px before and after the templates-related image, which results in excessive spacing between the sections.

I removed both the spacer blocks (above and below) and it is looking a bit better, think we can remove those spacers safely?

spacer-

@JohnPixle
Copy link
Contributor

Sorry, I just saw Harshit also mentioned the spacing issue, please disregard if already fixed 👍🏻

@preda-bogdan
Copy link
Contributor Author

@JohnPixle I've reduced the spacers to 100px, from 200px. You can let me know if it looks ok, I added them to resemble the design spacing, removing them entirely is also an option but the sections might be too close together.

@mghenciu
Copy link
Contributor

mghenciu commented May 4, 2023

Looking good, Bogdan, top work.
The only thing I noticed (and I think it was caused by Figma), is the border radius in the last image:
Screenshot 2023-05-04 at 19 37 30

meaning that all images have border radius, but the one on the right side is cut.

I've fixed it in Figma. Also fixed the other image from there that had some strange border.
Just re-exporting and replacing the image on the Landing Page - should fix the issues.

@preda-bogdan
Copy link
Contributor Author

@mghenciu Thank you, I've updated the image.

@JohnPixle
Copy link
Contributor

@preda-bogdan Spacing is fine now as it is, thanks for taking care of it 👍🏻

@JohnPixle
Copy link
Contributor

@preda-bogdan One final thing regarding this.

I believe we'll need a demosites.io/neve-fse site, where we can add the fse theme and build a proper demo. (instead of the testing site we now have at https://fse-neve.vertisite.cloud/

Also, the "view demo" button should link to the demosites site.

Think you can create a new domain and upload the theme build?
We will take care of the setup right after.

@preda-bogdan
Copy link
Contributor Author

@JohnPixle I've already did this for staging https://staging.demosites.io/neve-fse/ and will replicate it on live just for this purpose.

@JohnPixle
Copy link
Contributor

Awesome, thanks!! 🚀

@rodica-andronache
Copy link

@preda-bogdan not sure if you've already saw this, but on mobile, there is some big spacing in this section https://vertis.d.pr/i/fo3fGX and the content here https://vertis.d.pr/i/Yq0OER does not have left/right space

@preda-bogdan
Copy link
Contributor Author

@rodica-andronache Thank you for mentioning this, I've solved it on live. I am awaiting for some changes to be merged to Themeisle and will publish the page. 👍🏼

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new feature Request for a new feature or functionality to be added to the project. small (1-3h) This label is used for issues that can be completed within 3 hours or less.
Projects
None yet
Development

No branches or pull requests

5 participants