Skip to content

Commit e6945aa

Browse files
Merge pull request #921 from Codeinwp/bugfix/920
Fix axis data format issue
2 parents a5af309 + ccecd30 commit e6945aa

File tree

1 file changed

+22
-14
lines changed

1 file changed

+22
-14
lines changed

js/render-chartjs.js

Lines changed: 22 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@
6565
for (i = 0; i < data.length; i++) {
6666
row = [];
6767
for (j = 0; j < series.length; j++) {
68-
if (series[j].type === 'date' || series[j].type === 'datetime') {
68+
if (series[j].type === 'date' || series[j].type === 'datetime') {
6969
date = new Date(data[i][j]);
7070
data[i][j] = null;
7171
if (Object.prototype.toString.call(date) === "[object Date]") {
@@ -349,19 +349,22 @@
349349
// format the axes labels.
350350
if(typeof settings[axis + '_format'] !== 'undefined' && settings[axis + '_format'] !== ''){
351351
var format = settings[axis + '_format'];
352-
switch(axis){
353-
case 'xAxes':
354-
settings.scales.x.ticks.callback = function(value, index, values){
355-
return format_datum(value, format);
356-
};
357-
break;
358-
case 'yAxes':
359-
settings.scales.y.ticks.callback = function(value, index, values){
360-
return format_datum(value, format);
361-
};
362-
break;
363-
}
364-
delete settings[axis + '_format'];
352+
var isDateFormat = moment( moment().format( format ),format, true ).isValid();
353+
if ( ! isDateFormat ) {
354+
switch(axis){
355+
case 'xAxes':
356+
settings.scales.x.ticks.callback = function(value, index, values){
357+
return format_datum(value, format);
358+
};
359+
break;
360+
case 'yAxes':
361+
settings.scales.y.ticks.callback = function(value, index, values){
362+
return format_datum(value, format);
363+
};
364+
break;
365+
}
366+
delete settings[axis + '_format'];
367+
}
365368
}
366369
delete settings[axis];
367370
}
@@ -445,6 +448,11 @@
445448
function format_data(datum, j, settings, series){
446449
j = j - 1;
447450
var format = typeof settings.series !== 'undefined' && typeof settings.series[j] !== 'undefined' ? settings.series[j].format : '';
451+
if ( '' === format && typeof settings.yAxes_format !== 'undefined' ) {
452+
format = settings.yAxes_format;
453+
} else if ( '' === format && typeof settings.xAxes_format !== 'undefined' ) {
454+
format = settings.xAxes_format;
455+
}
448456
return format_datum(datum, format, series[j + 1].type);
449457
}
450458

0 commit comments

Comments
 (0)