Skip to content

Commit 9ccf1cd

Browse files
authored
rename no-package-libraries to dart-internal-objects (flutter#4954)
1 parent 9ae7a69 commit 9ccf1cd

File tree

6 files changed

+4
-5
lines changed

6 files changed

+4
-5
lines changed

packages/devtools_app/lib/src/screens/memory/panes/diff/widgets/class_filter_dialog.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -135,5 +135,5 @@ const _helpText = 'Choose and customize the filter.\n'
135135
' MyClass\n'
136136
' package:myPackage/src/\n\n'
137137
'Specify:\n'
138-
' - ${ClassFilter.noPackageLibrariesAlias} for classes without package prefix\n'
138+
' - ${ClassFilter.dartInternalAlias} for dart internal objects, not assigned to any package\n'
139139
' - ${ClassFilter.dartAndFlutterLibrariesAlias} for most "dart:" and "package:" libraries published by Dart and Flutter orgs.';

packages/devtools_app/lib/src/screens/memory/shared/heap/class_filter.dart

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -36,15 +36,15 @@ class ClassFilter {
3636
ClassFilter.empty()
3737
: this(
3838
filterType: ClassFilterType.showAll,
39-
except: '$noPackageLibrariesAlias\n$dartAndFlutterLibrariesAlias',
39+
except: '$dartInternalAlias\n$dartAndFlutterLibrariesAlias',
4040
only: null,
4141
);
4242

4343
static String _trimByLine(String value) =>
4444
value.split('\n').map((e) => e.trim()).join('\n');
4545

4646
static const String dartAndFlutterLibrariesAlias = '\$dart-flutter-libraries';
47-
static const String noPackageLibrariesAlias = '\$no-package-libraries';
47+
static const String dartInternalAlias = '\$dart-internal-objects';
4848

4949
final ClassFilterType filterType;
5050
final String except;
@@ -140,8 +140,7 @@ class ClassFilter {
140140
if (className.fullName.contains(filter)) return true;
141141
if (filter == dartAndFlutterLibrariesAlias && className.isDartOrFlutter)
142142
return true;
143-
if (filter == noPackageLibrariesAlias && className.isPackageless)
144-
return true;
143+
if (filter == dartInternalAlias && className.isPackageless) return true;
145144
return false;
146145
}
147146
}
16 Bytes
Loading
-39 Bytes
Loading
-40 Bytes
Loading
-40 Bytes
Loading

0 commit comments

Comments
 (0)