Skip to content

Commit 6f7ffd1

Browse files
auto-submit[bot]CoderDake
authored andcommitted
Reverts "[web] Re-enable test now that source of flakiness is fixed" (flutter#140515)
Reverts flutter#140462 Initiated by: cbracken This change reverts the following previous change: Original Description: The test was flaky before due to overflowing GPU memory during the test. The memory leak was fixed here flutter/engine#49214 Fixes flutter#137669 As a side effect of the fix, this test also runs much faster, from about 3 minutes on my Macbook down to about 25 seconds.
1 parent 164cf74 commit 6f7ffd1

File tree

1 file changed

+7
-4
lines changed

1 file changed

+7
-4
lines changed

packages/flutter/test/cupertino/text_field_test.dart

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -8390,10 +8390,13 @@ void main() {
83908390
final EditableText editableText = tester.firstWidget(find.byType(EditableText));
83918391
expect(editableText.clipBehavior, Clip.none);
83928392

8393-
await expectLater(
8394-
find.byKey(const ValueKey<int>(1)),
8395-
matchesGoldenFile('overflow_clipbehavior_none.cupertino.0.png'),
8396-
);
8393+
// TODO(harryterkelsen): see https://github.com/flutter/flutter/issues/137669
8394+
if (!kIsWeb || !isCanvasKit) {
8395+
await expectLater(
8396+
find.byKey(const ValueKey<int>(1)),
8397+
matchesGoldenFile('overflow_clipbehavior_none.cupertino.0.png'),
8398+
);
8399+
}
83978400
});
83988401

83998402
testWidgets('can shift + tap to select with a keyboard (Apple platforms)', (WidgetTester tester) async {

0 commit comments

Comments
 (0)