Move create membership to upsert

Author: patch0

clubs/handlers/createMember.js

@@ -17,7 +17,7 @@ module.exports = [
     const { userId, userType } = req.body;
     const { id: dojoId } = req.params;
     try {
-      return res.send(await memberController.create(userId, dojoId, userType));
+      return res.send(await memberController.upsert(userId, dojoId, userType));
     } catch (e) {
       next(e);
     }

clubs/routes.js

@@ -4,5 +4,5 @@ const handlers = require('./handlers');
 
 const clubRouter = express.Router();
 clubRouter.get('/:id', validations.load, handlers.load);
-clubRouter.post('/:id/members', validations.members.create, handlers.members.upsert);
+clubRouter.post('/:id/members', validations.members.create, handlers.members.create);
 module.exports = clubRouter;

test/unit/clubs/handlers/createMember.spec.js

@@ -13,7 +13,7 @@ describe('clubs/handlers:createMember', () => {
 
   before(() => {
     sandbox = sinon.createSandbox();
-    membershipsController.create = sandbox.stub();
+    membershipsController.upsert = sandbox.stub();
     clubsController.load = sandbox.stub();
     handlers = proxy('../../../../clubs/handlers/createMember', {
       '../../memberships/controller': membershipsController,
@@ -61,17 +61,17 @@ describe('clubs/handlers:createMember', () => {
     expect(next).to.have.been.calledWith(err);
   });
 
-  it('should create the membership', async () => {
+  it('should upsert the membership', async () => {
     req.body = {
       userId: 'u1',
       userType: 'champion',
     };
     req.params = {
       id: 'd1',
     };
-    membershipsController.create.resolves({ id: 'm1' });
+    membershipsController.upsert.resolves({ id: 'm1' });
     await handlers[1](req, res, next);
-    expect(membershipsController.create).to.have.been.calledOnce.and
+    expect(membershipsController.upsert).to.have.been.calledOnce.and
       .calledWith('u1', 'd1', 'champion');
     expect(res.send).to.have.been.calledWith({ id: 'm1' });
   });