Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tighten up configuration #42

Open
adamwight opened this issue Mar 27, 2015 · 2 comments
Open

Tighten up configuration #42

adamwight opened this issue Mar 27, 2015 · 2 comments

Comments

@adamwight
Copy link
Contributor

Interfaces\Config is unused. Tests and demo applications should be locally configured with a single file config.yaml.example, rather than in code.

I don't know what the config data should look like. It would be nice to include backend dependency injection, as well as defaults for each backend, but this seems like an overly complicated configuration file, it would look something like:

stomp:
    uri: tcp://host.localhost.net:61613
    read_timeout: 10

queues:
    test_stomp:
        backend: Stomp
@miccheng
Copy link
Member

Hmm... Does PHP have a sane and build in YAML parser yet?

@adamwight
Copy link
Contributor Author

I think package symfony/yaml is a good one, it's standalone and pure PHP.

On another note, sometimes we might want to provide configuration from calling code. Config::fromFile() and Config::fromArray() ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants