print to align with staveProfile and rithmMode

[circinusX1]

Adding to alphatab.js @ AlphaTabApi.prototype.print function

            settings.display.staveProfile=0;  
            settings.notation.rhythmMode=0; 
            if(this.settings.display.staveProfile=="score")         settings.display.staveProfile = 2;
            else if(this.settings.display.staveProfile=="tab")      settings.display.staveProfile = 3;
            if(this.settings.notation.rhythmMode=="ShowWithBars")   settings.notation.rhythmMode  = 2;

[Danielku15]

Can you maybe try to express your problem and idea in full sentences so we can have a discussion. From your code I do not really understand what you are trying to achieve.
You might want to check out the additionalSettings parameter introduced in 1.2 to pass in additional settings which should be considered during printing.

[circinusX1]

If I am changing api.settings.display.staveProfile with one of the options
(scoretab, score, tab) and alternately also api.settings.display.staveProfile with (ShowWithBars, hidden),
then I select print, it always printing/re-rendering scoretab (both score and tab).
The printing should get the settings into new Settings from the current settings

[Danielku15]

With alphaTab 1.2 any currently applied settings on the main API object are considered as base for printing:

[General] Respect original settings when printing and allow additional print settings (Issue: #469, PR: #486, Docs)
https://github.com/CoderLine/alphaTab/releases/tag/v1.2.0

It could also be that you are modifying the settings object wrongly. From your example you suggesting that you might be filling string values into the properties which are supposed to contain enum values. This is not supported. You either need to use the right data types like alphaTab.StaveProfile.ScoreTab to set the properties or you need to use fillFromJson to update the settings with textual enum values. Refer to the documentation page about settings (intro section) for more details.

If you face certain issues please file a full bug report or at least try to provide some details as part of this discussion. Just giving me some code snippet on how you want to modify alphaTab is not the right approach. I need to understand what actual issue you are facing and then we can define a proper solution to the problem.

[circinusX1]

Hi,
Thank you for your answer.
Is not an issue. You can close this topic please. I also have a link from the website I have to the licks database, if you don't mind.
I am using this version: alphaTab v1.1.0 (, build 3)
Here is my code for showing different views which works great.

The HTML:
 <div class="at-staff" title="Score view mode">
      <i class="fa  fa-eye" style="margin-right:-18px;"></i>
      <select  class='bg-transparent border'>
        <option value="2" selected>Tabs</option>
        <option value="0">Default</option>
        <option value="1">Score</option>
        <option value="3">Tabs+</option>
        <option value="4">Default+</option>
      </select>
    </div>

The JS:

    const vv = wrapper.querySelector(".at-controls .at-staff select");
    if(vv!=null){
        vv.onchange = () => {
            api.stop();
            const val = parseInt(vv.value);
            api.settings.notation.rhythmMode='Hidden';
            switch(val){
                default:
                case 0:  {api.settings.display.staveProfile = 'scoretab'};break;
                case 1:  {api.settings.display.staveProfile = 'score';}break;
                case 2:  {api.settings.display.staveProfile = 'tab';}break;
                case 3:  {api.settings.display.staveProfile = 'tab'; api.settings.notation.rhythmMode='ShowWithBars';}break;
                case 4:  {api.settings.display.staveProfile = 'scoretab'; api.settings.notation.rhythmMode='ShowWithBars';}break;
            }
            api.updateSettings();
            api.render();
        };
    }

The print

    const prin = wrapper.querySelector(".at-controls .at-print");
    if(prin!=null){
            prin.onclick = () => {
            const title = wrapper.querySelector(".at-song-title").innerText;
            if(title.length ==0 || title[0] != "@"){
                api.print();
            }else{
                extern_noprint(overlay);
            }
        };
    }

The print did not print the last view mode, therefore in the alphaTab.js I did the following, see /// print { tweaks

 // render alphaTab
            var settings = new Settings();

            settings.core.scriptFile = this.settings.core.scriptFile;
            settings.core.fontDirectory = this.settings.core.fontDirectory;
            settings.core.enableLazyLoading = false;
            settings.core.useWorkers = false;
            settings.display.scale = 0.8;
            settings.display.stretchForce = 0.8;
            settings.display.resources = this.settings.display.resources;

            settings.display.staveProfile=0;
           ///  print { tweaks
            settings.notation.rhythmMode=0;  // mco-mco-print
            if(this.settings.display.staveProfile=="score")         settings.display.staveProfile = 2;
            else if(this.settings.display.staveProfile=="tab")      settings.display.staveProfile = 3;
            if(this.settings.notation.rhythmMode=="ShowWithBars")   settings.notation.rhythmMode  = 2;
            ///  }
            var alphaTab = new AlphaTabApi(a4, settings);
            alphaTab.renderer.postRenderFinished.on(function () {
                alphaTab.canvasElement.height = -1;
                preview.print();
            });
            alphaTab.renderTracks(this.tracks);

[Danielku15]

As I have assumed: your manual modifications of the settings object is wrong and can lead to unexpected side effects. Instead of patching alphaTab to work with the wrong usage, you should correct your code to one of the following variants. Enums in alphaTab are meant to be numbers, passing in strings is only allowed on some dedicated inputs.

Variant 1: Use right data types

const vv = wrapper.querySelector(".at-controls .at-staff select");
if(vv!=null){
    vv.onchange = () => {
        api.stop();
        const val = parseInt(vv.value);
        api.settings.notation.rhythmMode = alphaTab.TabRhythmMode.Hidden;
        switch(val){
            default:
            case 0:  {api.settings.display.staveProfile = alphaTab.StaveProfile.ScoreTab;} break;
            case 1:  {api.settings.display.staveProfile = alphaTab.StaveProfile.Score;} break;
            case 2:  {api.settings.display.staveProfile = alphaTab.StaveProfile.Tab;} break;
            case 3:  {api.settings.display.staveProfile = alphaTab.StaveProfile.Tab; api.settings.notation.rhythmMode=alphaTab.TabRhythmMode.ShowWithBars;}break;
            case 4:  {api.settings.display.staveProfile = alphaTab.StaveProfile.ScoreTab; api.settings.notation.rhythmMode=alphaTab.TabRhythmMode.ShowWithBars;}break;
        }
        api.updateSettings();
        api.render();
    };
}

Variant 2: Use fillFromJson to parse string enums

const vv = wrapper.querySelector(".at-controls .at-staff select");
if(vv!=null){
    vv.onchange = () => {
        api.stop();
        const val = parseInt(vv.value);
        const newSettings = {
            notation: {
                rhythmMode: 'hidden'
            },
            display: {
                staveProfile: 'scoretab'
            }
        };
        switch(val){
            default:
            case 0:  {newSettings.display.staveProfile = 'scoretab'};break;
            case 1:  {newSettings.display.staveProfile = 'score';}break;
            case 2:  {newSettings.display.staveProfile = 'tab';}break;
            case 3:  {newSettings.display.staveProfile = 'tab'; newSettings.notation.rhythmMode='ShowWithBars';}break;
            case 4:  {newSettings.display.staveProfile = 'scoretab'; newSettings.notation.rhythmMode='ShowWithBars';}break;
        }
        api.settings.fillFromJson(newSettings);
        api.updateSettings();
        api.render();
    };
}

[circinusX1]

Hi, Thank you very much I will apply the changes as soon I would have some time.
Regards,
Marius