Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

After updating to patch commit b079e29, this error occurred:the cursor pauses at the end of each bar #1331

Closed
1 task done
goodgame365 opened this issue Dec 30, 2023 · 2 comments · Fixed by #1334
Closed
1 task done
Assignees
Labels
area-player Related to the audio playback engine. platform-all Affects all platforms state-accepted This is a valid topic to work on.

Comments

@goodgame365
Copy link

goodgame365 commented Dec 30, 2023

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

Sure, here's the translation: "When this sheet music is played, the cursor pauses at the end of each bar, possibly because it didn't consider the case of dividing two eighth notes into a triplet.

video demonstration here:
https://github.com/CoderLine/alphaTab/assets/17884664/37f3c2a5-57cb-45d5-86f6-e137066f40e5

when the score like :
未标题-1

Expected Behavior

Normal Playback

Steps To Reproduce

1、updating to patch commit b079e29
2、down this gp
t.zip

Link to jsFiddle, CodePen, Project

No response

Found in Version

1.3-alpha

Platform

Other

Environment

Any browserany

Anything else?

No response

@goodgame365 goodgame365 added the state-needs-triage Bug not triaged yet. label Dec 30, 2023
@goodgame365
Copy link
Author

goodgame365 commented Dec 30, 2023

This one is also

And it's a different situation

When there are multiple tracks, this situation is also likely to occur.
Parisienne Walkways.zip

20231230_225244.mp4

@Danielku15
Copy link
Member

With the reported files I noted following bugs to be fixed:

  1. With the triplet feel active the start and end times of beats appear to get reported wrongly. Instead of the 8 beats we can see there are 10 slots/slices in the tick lookup.
  2. There is a bug in the logic handling finding the next visible "slice". It doesn't continue the search to the next bar.
  3. We need to handle incomplete and overfilled bars with special cases matching the playback generation.

@Danielku15 Danielku15 added 🕷️ type-bug state-accepted This is a valid topic to work on. area-player Related to the audio playback engine. platform-all Affects all platforms and removed state-needs-triage Bug not triaged yet. labels Dec 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-player Related to the audio playback engine. platform-all Affects all platforms state-accepted This is a valid topic to work on.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants