Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve TypeScript types for JSON settings object #1561

Closed
Danielku15 opened this issue Jun 29, 2024 · 0 comments · Fixed by #1562
Closed

Improve TypeScript types for JSON settings object #1561

Danielku15 opened this issue Jun 29, 2024 · 0 comments · Fixed by #1562
Assignees
@Danielku15
Labels
area-core Related to some core parts of alphaTab platform-javascript Related to the JavaScript version of alphaTab state-accepted This is a valid topic to work on.
Milestone
1.4.0

Comments

@Danielku15
Copy link
Member

Also see #1558

We should try to have also some TypeScript type declarations for the "JSON" flavor of the settings object passed during initialization.

Also some better samples on https://www.alphatab.net/docs/reference/settings/display/resources#resources could help avoiding the confusion on how to set colors and fonts. .
@Danielku15 Danielku15 added 🚀 type-improvement state-accepted This is a valid topic to work on. platform-javascript Related to the JavaScript version of alphaTab area-core Related to some core parts of alphaTab labels Jun 29, 2024
@Danielku15 Danielku15 self-assigned this Jun 29, 2024
@Danielku15 Danielku15 mentioned this issue Jun 29, 2024
Merged
6 tasks
@Danielku15 Danielku15 moved this to In Progress in alphaTab 1.4-1.x Jun 29, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in alphaTab 1.4-1.x Jun 29, 2024
@Danielku15 Danielku15 added this to the 1.4.0 milestone Feb 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Danielku15 Danielku15

Labels
area-core Related to some core parts of alphaTab platform-javascript Related to the JavaScript version of alphaTab state-accepted This is a valid topic to work on.
Projects
alphaTab 1.4-1.x
Status: Done
Milestone
1.4.0
Development

Successfully merging a pull request may close this issue.

feat: Generate strong types for JSON serialized settings CoderLine/alphaTab
1 participant
@Danielku15