Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Effect Bands of reverted bars wrongly remember the height from the previous system. #1627

Closed
1 task done
goodgame365 opened this issue Aug 17, 2024 · 1 comment · Fixed by #1641
Closed
1 task done
Assignees
Labels
area-rendering Everything related to the rendering platform-all Affects all platforms state-accepted This is a valid topic to work on.
Milestone

Comments

@goodgame365
Copy link

goodgame365 commented Aug 17, 2024

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

I found that the issue still exists in commit 996d08a. This time, the rows below inherit the height of a certain effect from the row above, and the subsequent rows continue to inherit this height until a different effect is applied,As shown in the image:
未标题-1

未标题-3

Expected Behavior

I expect the effect to be as shown in the figure below
未标题-2

Steps To Reproduce

Please download this GTP file for testing
test2.zip

Link to jsFiddle, CodePen, Project

No response

Found in Version

1.4 (alpha) or 1.3.1

Platform

Web

Environment

Browser

Anything else?

No response

@goodgame365 goodgame365 added the state-needs-triage Bug not triaged yet. label Aug 17, 2024
@goodgame365
Copy link
Author

goodgame365 commented Aug 21, 2024

I found that commenting out or deleting \src\rendering\EffectBarRenderer.ts the following line of code makes the program display correctly:

  private updateHeight(): boolean {
       if (!this.sizingInfo) {
           return false;
       }
       let y: number = 0;
       for (let slot of this.sizingInfo.slots) {
           slot.shared.y = y;
           for (let band of slot.bands) {
               band.y = y;
               **//  commenting out or deleting  the following line
               //band.height = slot.shared.height;**
  



However, the reason is unclear, as I'm not sure what the purpose of this assignment is.

未标题-1

@Danielku15 Danielku15 added type-bug 🕷️ area-rendering Everything related to the rendering state-accepted This is a valid topic to work on. platform-all Affects all platforms and removed state-needs-triage Bug not triaged yet. labels Aug 23, 2024
@Danielku15 Danielku15 changed the title I found that there is still a problem; the subsequent rows continue to inherit the height of a certain effect from the row above Effect Bands of reverted bars wrongly remember the height from the previous system. Aug 23, 2024
@Danielku15 Danielku15 added this to the 1.4.0 milestone Feb 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-rendering Everything related to the rendering platform-all Affects all platforms state-accepted This is a valid topic to work on.
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants