Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ES5 properties for a more consistent API #270

Closed
Danielku15 opened this issue Aug 11, 2019 · 0 comments · Fixed by #273
Closed

Add ES5 properties for a more consistent API #270

Danielku15 opened this issue Aug 11, 2019 · 0 comments · Fixed by #273
Assignees
@Danielku15
Labels
platform-javascript Related to the JavaScript version of alphaTab state-accepted This is a valid topic to work on.
Milestone
1.0.0

Comments

@Danielku15
Copy link
Member

Danielku15 commented Aug 11, 2019 •
edited
Loading

Description

The properties in the JavaScript area are currently resulting in get_Prop and set_Prop methods in case they are computed. It would be great to generate ES5 properties that make the usage from the public API more consistent.

As part of this the casing of the javascript classes should be changed from PascalCase to camelCase.

Possible Solutions

Extend the compiler to generate some static initializer which will expose the properties.ö This haxe seems to be working:
HaxeFoundation/haxe#5104 (comment)
@Danielku15 Danielku15 self-assigned this Aug 11, 2019
@Danielku15 Danielku15 added state-accepted This is a valid topic to work on. improvement platform-javascript Related to the JavaScript version of alphaTab labels Aug 11, 2019
@Danielku15 Danielku15 added this to the 1.0.0 milestone Aug 11, 2019
@Danielku15 Danielku15 mentioned this issue Aug 27, 2019
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Danielku15 Danielku15

Labels
platform-javascript Related to the JavaScript version of alphaTab state-accepted This is a valid topic to work on.
Projects
None yet
Milestone
1.0.0
Development

Successfully merging a pull request may close this issue.

Introduces ES5 properites and camelCase naming conventions CoderLine/alphaTab
1 participant
@Danielku15