Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notes can't have both slide-ins and slide-outs #292

Closed
cheap-glitch opened this issue Nov 12, 2019 · 2 comments · Fixed by #330
Closed

Notes can't have both slide-ins and slide-outs #292

cheap-glitch opened this issue Nov 12, 2019 · 2 comments · Fixed by #330
Assignees
Labels
area-rendering Everything related to the rendering state-accepted This is a valid topic to work on.
Milestone

Comments

@cheap-glitch
Copy link

Your environment

  • Version used: latest (develop)
  • Platform used: JavaScript
  • Rendering engine used: SVG
  • Browser Name and Version: Firefox (latest)
  • Operating System and version (desktop or mobile): Linux (desktop)
  • Link to your project:

Expected Results

Slide-ins and slide-outs should be combinable, i.e. a note should be able to have both notations at the same time. Example in GP6:
screenshot-1573593566

Observed Results

The following alphatex snippet

r (8.2{sib sod} 9.3{sib sod})

produces this result:
Screenshot_2019-11-12 The Guitar Lick Database
The slide-in from below has been overwritten by the slide-out.

Steps to Reproduce (for bugs)

Create a tab with the following alphatex:

1.1{sib sod}
@Danielku15
Copy link
Member

This is indeed an issue which I did not consider so far. The internal data model of alphaTab does not foresee to have slides in and out. But obviously it should 😉

@Danielku15 Danielku15 self-assigned this Dec 2, 2019
@Danielku15 Danielku15 added state-accepted This is a valid topic to work on. improvement area-rendering Everything related to the rendering labels Dec 2, 2019
@Danielku15 Danielku15 added this to the 1.0.0 milestone Dec 2, 2019
@Danielku15
Copy link
Member

Version 0.9.6.279 has now support for combiend slide-ins and -outs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-rendering Everything related to the rendering state-accepted This is a valid topic to work on.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants