Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repeat measures fail to play properly, renderer can crash browser #294

Closed
chris-saunders opened this issue Nov 29, 2019 · 1 comment · Fixed by #314
Closed

Repeat measures fail to play properly, renderer can crash browser #294

chris-saunders opened this issue Nov 29, 2019 · 1 comment · Fixed by #314
Assignees
Labels
area-player Related to the audio playback engine. state-accepted This is a valid topic to work on.
Milestone

Comments

@chris-saunders
Copy link

Your environment

  • Version used: Develop Branch
  • Platform used: JavaScript
  • Rendering engine used: SVG (default)
  • Browser Name and Version: Chrome Version 78.0.3904.108 (Official Build) (64-bit)
  • Operating System and version (desktop or mobile): Mac OSX 10.14.6

Expected Results

When the player reaches the end of a repeated segment, the cursor moves back to the start and plays the segment again however many times is specified in the AlphaTex

Observed Results

Player frequently does not repeat at all, and when it does it does not repeat the given number of times. There is also no indication above the repeat lines specifying how many times to repeat a given section.

In addition repeats can cause the renderer to use so much memory google chrome crashes. I see 150% CPU utilization when trying to render some AlphaTex with repeats

Steps to Reproduce (for bugs)

Using the sample AlphaTex provided for repeats, the first repeat does not happen, and the second repeat (set to repeat 3 times) only repeats once.

\ro 1.3 2.3 3.3 4.3 |
5.3 6.3 7.3 8.3 |
\rc 2 1.3 2.3 3.3 4.3 |
\ro \rc 3 1.3 2.3 3.3 4.3 |

Using the same AlphaTex above but changing the repeat amounts causes the memory/render issue which crashes Chrome

\ro 1.3 2.3 3.3 4.3 |
5.3 6.3 7.3 8.3 |
\rc 3 1.3 2.3 3.3 4.3 |
\ro \rc 3 1.3 2.3 3.3 4.3 |
@Danielku15 Danielku15 self-assigned this Dec 2, 2019
@Danielku15 Danielku15 added 🕷️ bug state-accepted This is a valid topic to work on. area-player Related to the audio playback engine. labels Dec 2, 2019
@Danielku15 Danielku15 added this to the 1.0.0 milestone Dec 2, 2019
@Danielku15
Copy link
Member

Sounds like a nasty endless-loop somewhere inside the audio generation which piles up a lot of data until the browser crashes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-player Related to the audio playback engine. state-accepted This is a valid topic to work on.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants