Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support per track volume from Guitar Pro 7 file format #446

Closed
jordanske opened this issue Nov 29, 2020 · 2 comments
Closed

Support per track volume from Guitar Pro 7 file format #446

jordanske opened this issue Nov 29, 2020 · 2 comments
Assignees
@Danielku15
Labels
area-file-formats Related to supported file formats state-accepted This is a valid topic to work on.

Comments

@jordanske
Copy link
Contributor

Description

Currently when using .gp files from Guitar Pro 7 all track volumes are the default (15).
Alphatab does not use the track volumes set in Guitar Pro 7.

This works fine with .gp5 files but fails to do so with .gp.

Setting in Guitar Pro 7:
track volumes in Guitar Pro 7

Exported as .gp5:
track volumes in AlphaTab with .gp

Exported as .gp:
track volumes in AlphaTab with .gp

Possible Solutions

Modifying the gpif importer to support this.
I already created a pull request with a possible solution: #445

Current Workarounds

Using .gp5
@jordanske jordanske mentioned this issue Nov 29, 2020
Merged
@Danielku15 Danielku15 self-assigned this Nov 29, 2020
@Danielku15 Danielku15 added area-file-formats Related to supported file formats file-format-guitarpro state-accepted This is a valid topic to work on. labels Nov 29, 2020
@Danielku15 Danielku15 added this to the 1.2 milestone Nov 29, 2020
@Danielku15
Copy link
Member

Thanks for this finding and your planned contribution. Funny I never realized that the volume components are missing when read. It seems that also other parts like the balance are missing, would be good to add them too.

@Danielku15
Copy link
Member

Closed with #445

This was referenced Jan 17, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Danielku15 Danielku15

Labels
area-file-formats Related to supported file formats state-accepted This is a valid topic to work on.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jordanske @Danielku15