Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tab numbers position problem at some zoom levels #452

Closed
thoun opened this issue Dec 6, 2020 · 2 comments · Fixed by #483
Closed

Tab numbers position problem at some zoom levels #452

thoun opened this issue Dec 6, 2020 · 2 comments · Fixed by #483
Assignees
Labels
area-rendering Everything related to the rendering platform-javascript Related to the JavaScript version of alphaTab state-accepted This is a valid topic to work on.

Comments

@thoun
Copy link
Contributor

thoun commented Dec 6, 2020

Your environment

  • Version used: develop / demo on the website
  • Platform used: JavaScript
  • Rendering engine used: SVG
  • Browser Name and Version: Chrome 86 & Firefox too
  • Operating System and version (desktop or mobile): Windows 10
  • Link to your project: visible on https://alphatab.net/ demo page

Expected Results

Numbers are vertically centered to line on every zoom level

Observed Results

numbers are not aligned at 75% (ok with 50% and 90%)
atissue

Steps to Reproduce (for bugs)

Open https://alphatab.net/ and select 75% zoom

Possible Solution

No solution yet. I might try a MR if I find tome to look deeper to this bug.

@Danielku15 Danielku15 self-assigned this Dec 9, 2020
@Danielku15 Danielku15 added 🕷️ type-bug area-rendering Everything related to the rendering platform-javascript Related to the JavaScript version of alphaTab state-accepted This is a valid topic to work on. labels Dec 9, 2020
@Danielku15
Copy link
Member

The issue likely comes from the way the numbers are vertically aligned. To maintain compatibility with IE I had to change the way texts are vertically aligned. Instead of the old dominant-baseline="middle" or dominant-baseline="hanging" the centering works via dy="0.5ex" or dy="1.25ex".

With the latest market changes it might be worth reconsidering again the IE support and drop it. Bootstrap 5 will drop support, Microsoft will drop support in August 2021 for their M365 apps, Wordpress is considering it. I opened a discussion to find out if we could drop it.

Until then we either are able to solve it using the existing ex units or we could try to add some browser detection to use dx units only for IE.

@Danielku15 Danielku15 added this to the 1.2 milestone Dec 9, 2020
@thoun
Copy link
Contributor Author

thoun commented Dec 31, 2020

thanks for the correction !

This was referenced Jan 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-rendering Everything related to the rendering platform-javascript Related to the JavaScript version of alphaTab state-accepted This is a valid topic to work on.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants