Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AlphaSynth output pitch too high for combined bends (bend following a bend) #470

Closed
1 task
WolfgangD opened this issue Dec 21, 2020 · 2 comments · Fixed by #488
Closed
1 task

AlphaSynth output pitch too high for combined bends (bend following a bend) #470

WolfgangD opened this issue Dec 21, 2020 · 2 comments · Fixed by #488
Assignees
Labels
area-player Related to the audio playback engine. state-needs-investigation

Comments

@WolfgangD
Copy link

Happy to provide more details if needed, but here is what we've heard testing latest version on alphaTab.

Expected Results

Pitch output correctly (e.g. compare Guitar Pros output) for combined bends.

Observed Results

Pitch is too high (mostly 2 half tones higher) on a combined bend.

See for annotated errors. +2/2 means 2 half tones too high. +1/2 means 1 half tone too high.
Screen Shot 2020-12-16 at 18 50 59

Steps to Reproduce

  1. Load Notation_Legend.gp
  2. play bending bars UTF8 Strings Not Rendered #3-18

Version

Flavor

  • [X ] JavaScript

System

  • Mac OS Big Sur, Safari
options = {
                file: filename,
                core: {
                    engine: "svg"
                },
                player: {
                    soundFont: "FluidR3GM.sf2",
                    enableCursor: true,
                    enablePlayer: true,
                    enableUserInteraction: false
                },
                notation: {
                    elements: {
                        ScoreTitle: false,
                        ScoreSubTitle: false,
                        ScoreArtist: false,
                        ScoreAlbum: false,
                        ScoreWords: false,
                        ScoreMusic: false,
                        ScoreWordsAndMusic: false,
                        ScoreCopyright: false,
                        GuitarTuning: false,
                        TrackNames: false,
                        EffectMarker: false,
                        EffectTempo: false
                    },
                    notationMode: 'songbook'
                }
@Danielku15 Danielku15 added area-player Related to the audio playback engine. state-needs-investigation labels Dec 22, 2020
@Danielku15 Danielku15 added this to the 1.2 milestone Dec 22, 2020
@Danielku15
Copy link
Member

Thanks for reporting this. I thought I have tested the bends quite extensively and validated the right audio. But I fear the combined scenarios might be buggy. I will need to check if it is caused by the midi generation (which I hope) or if it is a side effect within the synth engine.

@Danielku15
Copy link
Member

Found the buggy parts. There were some left-over paths where for individual notes full beat-bends were generated. This resulted in double bends (beat+note).

This was referenced Jan 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-player Related to the audio playback engine. state-needs-investigation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants